From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C59B63858419 for ; Wed, 3 Nov 2021 04:09:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C59B63858419 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1A349kBc000929 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 3 Nov 2021 00:09:50 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1A349kBc000929 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 38DE51E813; Wed, 3 Nov 2021 00:09:46 -0400 (EDT) Message-ID: <4f9eafae-edc2-e835-c461-2865fd18b185@polymtl.ca> Date: Wed, 3 Nov 2021 00:09:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 1/9] sim: or1k: build with -Werror Content-Language: en-US To: Mike Frysinger , gdb-patches@sourceware.org References: <20211101045945.23481-1-vapier@gentoo.org> From: Simon Marchi In-Reply-To: <20211101045945.23481-1-vapier@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 3 Nov 2021 04:09:46 +0000 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2021 04:10:01 -0000 On 2021-11-01 00:59, Mike Frysinger via Gdb-patches wrote: > The only warnings left in this port are a few maybe-uninitialized, > but we don't abort the build for them, so turn on -Werror everywhere. > --- > sim/or1k/Makefile.in | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/sim/or1k/Makefile.in b/sim/or1k/Makefile.in > index 8f447fdc291a..c6bd03b756cd 100644 > --- a/sim/or1k/Makefile.in > +++ b/sim/or1k/Makefile.in > @@ -55,9 +55,6 @@ SIM_EXTRA_LIBS =3D -lm > =20 > SIM_EXTRA_CLEAN =3D or1k-clean > =20 > -# Code doesn't build cleanly yet. > -SIM_WERROR_CFLAGS =3D > - > ## COMMON_POST_CONFIG_FRAG > =20 > arch =3D or1k >=20 Hi, I get: make[3]: Entering directory '/home/simark/build/binutils-gdb/sim/or1k' ccache gcc -DHAVE_CONFIG_H -DWITH_TARGET_WORD_BITSIZE=3D32 -DWITH_TARGET= _WORD_MSB=3D31 -DWITH_TARGET_ADDRESS_BITSIZE=3D32 -DWITH_HW=3D1 -DHAVE_D= V_SOCKSER -DDEFAULT_INLINE=3D0 -Wall -Wdeclaration-after-statement -Wpoin= ter-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-c= har-subscripts -Wempty-body -Wunused-but-set-parameter -Wno-error=3Dmaybe= -uninitialized -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-= after-statement -Wmissing-parameter-type -Wpointer-sign -Wold-style-decla= ration -Werror -I. -I/home/simark/src/binutils-gdb/sim/or1k -I../common = -I/home/simark/src/binutils-gdb/sim/or1k/../common -I../../include -I/hom= e/simark/src/binutils-gdb/sim/or1k/../../include -I../../bfd -I/home/sima= rk/src/binutils-gdb/sim/or1k/../../bfd -I../../opcodes -I/home/simark/src= /binutils-gdb/sim/or1k/../../opcodes -I../.. -I/home/simark/src/binutils= -gdb/sim/or1k/../../gnulib/import -I../../gnulib/import -g3 -O0 -fsaniti= ze=3Daddress -fmax-errors=3D1 -fdiagnostics-color=3Dalways -c -o mloop.= o -MT mloop.o -MMD -MP -MF .deps/mloop.Tpo mloop.c mloop.c:65:1: error: =E2=80=98or1k32bf_emit_after=E2=80=99 defined but no= t used [-Werror=3Dunused-function] 65 | or1k32bf_emit_after (SIM_CPU *current_cpu, SCACHE *sc, PCADDR pc)= | ^~~~~~~~~~~~~~~~~~~ Simon