From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61103 invoked by alias); 8 Aug 2017 20:59:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61090 invoked by uid 89); 8 Aug 2017 20:59:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Aug 2017 20:59:21 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 25D51883C7 for ; Tue, 8 Aug 2017 20:59:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 25D51883C7 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths@redhat.com Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1D925E27E; Tue, 8 Aug 2017 20:59:19 +0000 (UTC) Subject: Re: [PATCH 29/40] Simplify completion_list_add_name | remove sym_text / sym_text_len To: Pedro Alves , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-30-git-send-email-palves@redhat.com> From: Keith Seitz Message-ID: <4fbd05b5-c968-5e7e-ea01-fa85fd87ccdb@redhat.com> Date: Tue, 08 Aug 2017 20:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1496406158-12663-30-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00157.txt.bz2 On 06/02/2017 05:22 AM, Pedro Alves wrote: > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * ada-lang.c (ada_make_symbol_completion_list): Remove text and > text_len locals and don't pass them down. > * symtab.c (completion_list_add_name): Remove > sym_text/sym_text_len parameters and adjust. > (completion_list_add_symbol, completion_list_add_msymbol) > (completion_list_objc_symbol, completion_list_add_fields) > (add_symtab_completions): Likewise. > (default_collect_symbol_completion_matches_break_on) > (collect_file_symbol_completion_matches): Remove sym_text_len > local and don't pass it down. > * symtab.h (completion_list_add_name): Remove > sym_text/sym_text_len parameters. LGTM Keith