From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 33C873858CDA for ; Fri, 23 Sep 2022 21:35:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 33C873858CDA Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 10BA61F890; Fri, 23 Sep 2022 21:35:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EACEA13A00; Fri, 23 Sep 2022 21:35:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZCoxOLomLmN5MwAAMHmgww (envelope-from ); Fri, 23 Sep 2022 21:35:54 +0000 Message-ID: <4fe6a9e7-9b87-2755-b741-3a06180cdcc3@suse.de> Date: Fri, 23 Sep 2022 23:35:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 0/3] Fix gdb.gdb/python-helper.exp + cleanups Content-Language: en-US To: Luis Machado , Simon Marchi , gdb-patches@sourceware.org References: <20220923141801.1106678-1-simon.marchi@polymtl.ca> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2022 21:35:58 -0000 On 9/23/22 19:02, Luis Machado via Gdb-patches wrote: > On 9/23/22 15:17, Simon Marchi via Gdb-patches wrote: >> My patches that touched TYPE_LENGTH and TYPE_TARGET_TYPE caused >> regressions in gdb.gdb/python-helper.exp.  I forgot to update >> gdb-gdb.py.in, as always. >> >> It looks like my CI doesn't run the test properly.  Because inserting the >> first breakpoint times out, do_self_tests skips the test.  I also had >> troubles running the test locally due to these timeouts.  So the first >> two patches address problems related to that, and the third one is the >> actual fix. >> >> Simon Marchi (3): >>    gdb/testsuite: bump duration for the whole test in do_self_tests >>    gdb/testsuite: use gdb_test in gdb.gdb/python-helper.exp >>    gdb/testsuite: update field names in gdb-gdb.py.in >> >>   gdb/gdb-gdb.py.in                       |  4 +- >>   gdb/testsuite/gdb.gdb/python-helper.exp | 88 +++++-------------------- >>   gdb/testsuite/lib/gdb.exp               |  8 +-- >>   gdb/testsuite/lib/selftest-support.exp  | 36 +++------- >>   4 files changed, 31 insertions(+), 105 deletions(-) >> >> >> base-commit: 8e037eae6823caf5b9cb5b4feb3de838abb25956 > > Thanks for the series. I tested this on my end and it seems to work nicely. > > The only hiccup I noticed is when GDB runs into a SIGSEGV due to the guile > interpreter hitting GC_find_limit_with_bound. I'm not sure why this > happens. Maybe > it is a problem with guile and armhf. It's documented behaviour of libgc1, see https://sourceware.org/bugzilla/show_bug.cgi?id=29325 . Thanks, - Tom > > I don't think it is a flaw with the patch though. We'd have to go out of > our way > to handle something like this in the testcase. > > So this series LGTM.