From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A7DFB3858D33 for ; Wed, 1 Feb 2023 17:03:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7DFB3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1B53C1E112; Wed, 1 Feb 2023 12:03:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675270982; bh=O8Ba/wA4+DKaybo8JgwD6yJZKGCcEK7UUH7+SIZmpSM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=W+XP5LeXDOCujip++5py/XMfiiwfOqUSNRlwtg9RImEeXwx8qsKHwHbKZeyTT5R9+ GyfdCXMh21soZXey9jy+u23/l4aszURTTExBPfuTYQNXk4GwTg8FwMbQpzmArqFgsD 7Lm8+MebsUTeCiVGAzZzqlqzvqW5i2MbZkGReies= Message-ID: <502f0bd0-9b18-9a31-0094-7a9bd4778bd2@simark.ca> Date: Wed, 1 Feb 2023 12:03:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 5/8] gdbserver: Transmit target description ID in thread list and stop reply Content-Language: en-US To: Andrew Burgess , Thiago Jung Bauermann via Gdb-patches Cc: Thiago Jung Bauermann , Simon Marchi References: <20230130044518.3322695-1-thiago.bauermann@linaro.org> <20230130044518.3322695-6-thiago.bauermann@linaro.org> <87bkmdtp4n.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87bkmdtp4n.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Having read some of the later patches, I have some additional thoughts > here: > > I think we should make it explicit here that IDs are connection wide, > not per-process. We should also make it clear that GDB might[1] cache > target descriptions per remote connection, and so a remote target should > not reuse a target description ID except where the target description is > identical. > > [1] I say "GDB might" here because if we say "GDB will" then this would > imply each target description will only be asked for once. And I > figure, why be overly restrictive. Thanks for pointing this out, I had the same thought while reading the patch. In my original idea, I imagined that target description IDs could be some hashes computed from the XML content (a bit like git hashes or ELF build IDs), such that a given target description would always have the same ID. This would give clients the possibility to cache target descriptions locally, a bit like the index cache. It did sound nice, but perhaps it's not really important. Simon