From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 9A615385DC35 for ; Thu, 25 Jun 2020 09:18:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9A615385DC35 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-121-umqD5lHCOKq8zM5PdEq0Hg-1; Thu, 25 Jun 2020 05:18:03 -0400 X-MC-Unique: umqD5lHCOKq8zM5PdEq0Hg-1 Received: by mail-wm1-f72.google.com with SMTP id a7so6422584wmf.1 for ; Thu, 25 Jun 2020 02:18:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YPE9f4DhRn4akHSVmCM2S1hRXwUu3PZSNXpZDJNpsjE=; b=mhmgdtRPfcBJtjA+UdUKkJX7Ks1XukXjA3jtSXPa9v7scOGtuLu3ebWXOW1oCWkTsC ktvTlpzWhpi+WNKlJDtOBVqdFayNf0XZN1+Cr6Hxvff3KAKxse9xR13iITzN9/LnZbKK DmaAKykI9PgWJ7aYgmTC3JexgX+V0hYcu8B0lWF8J0DcKvVnX4J9AMAdsRAdRQBP/Xec 4CQ2sJ1eA25WVjdFscV2NWVmz+fvQGqo2rOWYCjDxqgK4G1wXkbCT+zLN3OBsZHmAqhQ vWFLwtcoFXZlnnS9HHBRuiFIo/ajVrjZKw3ipQTiPzDfWEzysOkbGz11ODOB0TyDQN7A +NGQ== X-Gm-Message-State: AOAM531xklY66E8Er15FQioouLwS1ZLOveQ5HqjzhjjDHp0kkql3ocLs 6vMqN513QTLhDB9jfuyD5uCYDqDlvChK9j0lbEzU5+F3hIVISlDC8JhybY1kJKXI0hU2JveGJGw RkRRdeMW1t8eqfFoXgAmdeQ== X-Received: by 2002:adf:8104:: with SMTP id 4mr4988945wrm.18.1593076682477; Thu, 25 Jun 2020 02:18:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw57voiAvsfQSyPVxHNtzjIcyVslAQ0c9Y9+WdAYJUYj15oj9qkTnGobdUz1OeCKlSHoRYaXA== X-Received: by 2002:adf:8104:: with SMTP id 4mr4988931wrm.18.1593076682288; Thu, 25 Jun 2020 02:18:02 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id d28sm33149407wrc.50.2020.06.25.02.18.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2020 02:18:01 -0700 (PDT) Subject: Re: [PATCH] Remove obsolete gdbarch_static_transform_name To: Rainer Orth , Simon Marchi References: <00d11a67-fb37-52de-859d-f8055c841668@simark.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <503ab954-fc05-ba9b-6418-32ca92e466bb@redhat.com> Date: Thu, 25 Jun 2020 10:18:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 09:18:06 -0000 On 6/25/20 9:26 AM, Rainer Orth wrote: > case 'X': > - /* SunPRO (3.0 at least) static variable encoding. */ > - if (gdbarch_static_transform_name_p (gdbarch)) > - goto normal; > /* fall through */ > If you're leaving the case 'X': then I think you should leave a comment in place about that is about. But I'd just remove that case X line, since the fallthrough is to the default case anyway. Thanks, Pedro Alves