From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1024 invoked by alias); 15 Feb 2017 09:30:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 958 invoked by uid 89); 15 Feb 2017 09:30:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=$hex, H*r:Wed, gdb_breakpoint, $decimal X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Feb 2017 09:30:22 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cdvul-00063C-5j from Luis_Gustavo@mentor.com ; Wed, 15 Feb 2017 01:30:19 -0800 Received: from [172.30.12.49] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 15 Feb 2017 01:30:15 -0800 Reply-To: Luis Machado Subject: Re: [PATCH] [trivial] Fix test names starting with uppercase in gdb.arch/ppc64-atomic-inst.exp References: <1486350182-13993-1-git-send-email-emachado@linux.vnet.ibm.com> <38fe05a1-770c-e9f1-ecc0-042dfe0a470e@codesourcery.com> <1d9ca4d1-7101-e16d-4f78-93991f3d4d15@linux.vnet.ibm.com> To: Edjunior Barbosa Machado , CC: From: Luis Machado Message-ID: <50421755-b63b-5068-8e09-366e97cd890d@codesourcery.com> Date: Wed, 15 Feb 2017 09:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1d9ca4d1-7101-e16d-4f78-93991f3d4d15@linux.vnet.ibm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00403.txt.bz2 On 02/13/2017 09:35 PM, Edjunior Barbosa Machado wrote: > On 02/06/2017 08:03 AM, Luis Machado wrote: >>> @@ -52,6 +54,18 @@ proc do_test { displaced } { >>> gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \ >>> "Set the breakpoint at the start of the ldarx/stdcx sequence" >>> >>> + set bp3 [gdb_get_line_number "lbarx"] >>> + gdb_breakpoint "$bp3" "Breakpoint $decimal at $hex" \ >>> + "Set the breakpoint at the start of the lbarx/stbcx sequence" >> >> I think my previous set of testsuite fixups failed to catch these test >> names starting with uppercase. But we're requiring test names to start >> with lowercase now. I can address the rest of the offenders in a future >> patch, but new code should have the right format. >> > > Hi, > this trivial patch fixes the test names starting with uppercase using gdb_test > in gdb.arch/ppc64-atomic-inst.exp. > > Thanks, > -- > Edjunior > > gdb/testsuite/ > 2017-02-14 Edjunior Barbosa Machado > > * gdb.arch/ppc64-atomic-inst.exp: Fix test names starting with > uppercase. > > --- > gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp > index d1b3a7d..7bfff6c 100644 > --- a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp > +++ b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp > @@ -46,23 +46,23 @@ proc do_test { displaced } { > > set bp1 [gdb_get_line_number "lwarx"] > gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \ > - "Set the breakpoint at the start of the lwarx/stwcx sequence" > + "set the breakpoint at the start of the lwarx/stwcx sequence" > > set bp2 [gdb_get_line_number "ldarx"] > gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \ > - "Set the breakpoint at the start of the ldarx/stdcx sequence" > + "set the breakpoint at the start of the ldarx/stdcx sequence" > > gdb_test continue "Continuing.*Breakpoint $decimal.*" \ > - "Continue until lwarx/stwcx start breakpoint" > + "continue until lwarx/stwcx start breakpoint" > > gdb_test nexti "bne.*1b" \ > - "Step through the lwarx/stwcx sequence" > + "step through the lwarx/stwcx sequence" > > gdb_test continue "Continuing.*Breakpoint $decimal.*" \ > - "Continue until ldarx/stdcx start breakpoint" > + "continue until ldarx/stdcx start breakpoint" > > gdb_test nexti "bne.*1b" \ > - "Step through the ldarx/stdcx sequence" > + "step through the ldarx/stdcx sequence" > } > > foreach displaced { "off" "on" } { > LGTM.