From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, <gdb-patches@sourceware.org>
Subject: Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c
Date: Mon, 16 Oct 2017 22:37:00 -0000 [thread overview]
Message-ID: <508b908a-943d-e9ca-55ef-18e0dca0d7cd@ericsson.com> (raw)
In-Reply-To: <87wp3zowki.fsf@tromey.com>
On 2017-10-13 12:13 PM, Tom Tromey wrote:
> Tom> It turns out that with gdb::optional, you don't have to untangle it.
> Tom> I'm testing a patch to convert the rest of disasm.c away from cleanups.
>
> How about this?
>
> Tom
>
> commit 1b83351de30ed32808aa8b09d720556d423e57c6
> Author: Tom Tromey <tom@tromey.com>
> Date: Thu Oct 12 15:07:35 2017 -0600
>
> Remove cleanups from disasm.c
>
> This changes the remaining spots in disasm.c to use the RAII ui-out
> emitters, removing a few cleanups. This also fixes a regression that
> Simon pointed out.
>
> 2017-10-12 Tom Tromey <tom@tromey.com>
>
> * disasm.c (do_mixed_source_and_assembly_deprecated): Use
> gdb::optional, ui_out_emit_list, ui_out_emit_tuple.
> (do_mixed_source_and_assembly): Likewise.
That looks good to me (though I'm a bit overwhelmed by that code).
The regression I pointed out is fixed, mi-disassemble.exp passes and I manually
tested with the disassembly view of Eclipse, which exercises that code. So I
think it's safe enough.
Thanks!
Simon
next prev parent reply other threads:[~2017-10-16 22:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 15:35 [RFA 0/7] more ui-out cleanup removal Tom Tromey
2017-09-09 15:35 ` [RFA 4/7] Use ui_out_emit_tuple in disasm.c Tom Tromey
2017-09-09 18:35 ` Simon Marchi
2017-10-12 15:37 ` Simon Marchi
2017-10-12 16:06 ` Simon Marchi
2017-10-12 16:11 ` Tom Tromey
2017-10-12 21:07 ` Tom Tromey
2017-10-13 16:13 ` Tom Tromey
2017-10-16 22:37 ` Simon Marchi [this message]
2017-10-16 22:59 ` Tom Tromey
2017-09-09 15:35 ` [RFA 1/7] Use ui_out_emit_table and ui_out_emit_list in print_thread_info_1 Tom Tromey
2017-09-09 17:47 ` Simon Marchi
2017-09-09 18:36 ` Tom Tromey
2017-09-09 19:20 ` Matt Rice
2017-09-09 15:35 ` [RFA 6/7] Remove make_cleanup_ui_out_redirect_pop Tom Tromey
2017-09-09 18:49 ` Simon Marchi
2017-09-09 15:35 ` [RFA 5/7] Use ui_out_emit_list in more places Tom Tromey
2017-09-09 18:43 ` Simon Marchi
2017-09-09 15:35 ` [RFA 3/7] Use ui_out_emit_tuple " Tom Tromey
2017-09-09 18:32 ` Simon Marchi
2017-09-09 19:32 ` Tom Tromey
2017-09-09 15:46 ` [RFA 2/7] Remove make_cleanup_ui_out_table_begin_end Tom Tromey
2017-09-09 16:02 ` Tom Tromey
2017-09-09 18:22 ` Simon Marchi
2017-09-09 15:46 ` [RFA 7/7] Use ui_out_emit_list and ui_out_emit_tuple with gdb::optional Tom Tromey
2017-09-09 18:51 ` Simon Marchi
2017-09-09 19:44 ` [RFA 0/7] more ui-out cleanup removal Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508b908a-943d-e9ca-55ef-18e0dca0d7cd@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).