From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Small improvements to the remote protocol manual
Date: Fri, 02 Dec 2016 11:59:00 -0000 [thread overview]
Message-ID: <50947c4e-b4f8-a1ca-70bd-5be6e6a70b3d@redhat.com> (raw)
In-Reply-To: <1473819514-18403-1-git-send-email-tom@tromey.com>
Took me this long to get to reading this email...
On 09/14/2016 03:18 AM, Tom Tromey wrote:
> @@ -36047,10 +36053,11 @@ also the @samp{w} (@ref{thread exit event}) remote reply below.
> The process exited, and @var{AA} is the exit status. This is only
> applicable to certain targets.
>
> -The second form of the response, including the process ID of the exited
> -process, can be used only when @value{GDBN} has reported support for
> -multiprocess protocol extensions; see @ref{multiprocess extensions}.
> -The @var{pid} is formatted as a big-endian hex string.
> +The second form of the response, including the process ID of the
> +exited process, can be used only when @value{GDBN} has reported
> +support for multiprocess protocol extensions; see @ref{multiprocess
> +extensions}. Both @var{AA} and @var{pid} are formatted as big-endian
> +hex strings.
For the record, note that:
- the format of @var{AA} used to be exactly two hex chars:
/* GDB used to accept only 2 hex chars here. Stubs should
only send more if they detect GDB supports multi-process
support. */
p = unpack_varlen_hex (&buf[1], &value);
- The RSP overview states that "Except where otherwise noted all numbers
are represented in hex with leading zeros suppressed."
I've pondered before about removing all the explicit mentions of hex
encoding, in order to make the exceptions stand out. My idea would be
that if packets don't mention the formatting of numbers, then people
will naturally look for that in general packet formatting description.
But in the current state of the manual, it certainly doesn't hurt to
be explicit.
Thanks for the fixes.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-12-02 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 2:19 Tom Tromey
2016-09-14 22:58 ` Tom Tromey
2016-09-15 16:09 ` Yao Qi
2016-09-15 16:14 ` Tom Tromey
2016-12-02 11:58 ` Pedro Alves
2016-09-27 16:44 ` Tom Tromey
2016-09-27 17:46 ` Eli Zaretskii
2016-09-27 19:39 ` Tom Tromey
2016-09-27 19:47 ` Eli Zaretskii
2016-09-28 18:42 ` Tom Tromey
2016-12-02 11:59 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50947c4e-b4f8-a1ca-70bd-5be6e6a70b3d@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).