From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7215 invoked by alias); 7 Nov 2012 16:07:17 -0000 Received: (qmail 7141 invoked by uid 22791); 7 Nov 2012 16:07:15 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Nov 2012 16:07:05 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA7G6uuQ022035 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Nov 2012 11:06:56 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qA7G6spK021722; Wed, 7 Nov 2012 11:06:55 -0500 Message-ID: <509A871E.4030700@redhat.com> Date: Wed, 07 Nov 2012 16:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] partial fix PR 14777: Add abbrev cmd 'fo' for 'forward-search'. References: <1352293267-6640-1-git-send-email-yao@codesourcery.com> <20121107151342.GG5103@adacore.com> In-Reply-To: <20121107151342.GG5103@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00150.txt.bz2 On 11/07/2012 03:13 PM, Joel Brobecker wrote: >> We can fix this problem in two ways, either remove this line above >> from the doc or define "fo" as the abbreviated command of >> 'forward-search'. IMO, latter is better, so this is what this patch >> does. > > I tend to agree. > >> gdb/doc: >> 2012-11-07 Yao Qi >> >> * gdb.texinfo (Search): Add kindex for 'fo'. > > Needs approval from Eli. > >> gdb: >> 2012-11-07 Yao Qi >> >> PR gdb/14777. >> * source.c (_initialize_source): Call add_com_alias to abbreviate >> 'forward-search' as 'fo'. > > OK. > > I should also add that we should make sure that we do not approve > updates to the manual that document command abbreviations without > specifically defining the abbreviation in our code. As demonstrated > in this case, implicit abbreviations may become ambiguous over time. Yeah. It just looks like an oversight of early development. I see the forward-search command as early as GDB 2.5.1 (1988), and the "fo" abbreviation was already documented in gdb-3.3 (1989), the first release we have that includes the manual. I don't see an explicit abbreviation implemented anywhere in between those releases. -- Pedro Alves