From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id D1F203858D20 for ; Tue, 1 Mar 2022 18:25:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1F203858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 9B2A7816CC; Tue, 1 Mar 2022 18:25:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K7Qf83k6Mz4gmF; Tue, 1 Mar 2022 18:25:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646159120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EteEi3fAuWERS4GOXUnrgx92BwI2Yiwi0/xt551QAcU=; b=xE/POB04H5xjYzX2qvk46kyRYujLItB5WQAo1YnzJZjOfp/TPw3+oeBPZsoekjiqsuA8p2 kWtZzD01+WcM1XPnNGPpYxegSVHpplo+x87u/MamZAGnsKKveUsx5jd16ImuW0zsNHzxyS wiLFrqo76kIrYlPLvi7DzyRzysV/Cj/byaG+gSvUZrmeWsLFqabS9s1SxG5KX3M8h6zfVF dG62bbiw/ADXUY/AUjnsz6wJ+5CB6/3wMDJMSTtmvmrXRVgo33V7y+nPR1T6B3/8AQiJpA WPIe8Wy/Icj1+YCLgRV1CVbDUuGogg+mg65gyyut5DoGWvMosphU8fvNLHSyLQ== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 196319BA9; Tue, 1 Mar 2022 18:25:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <50bc80e8-3934-9585-3204-6ba4b0821986@FreeBSD.org> Date: Tue, 1 Mar 2022 10:25:18 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 1/3] i386-fbsd-nat: Assume PT_GETXMMREGS is present. Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220228223539.93563-1-jhb@FreeBSD.org> <20220228223539.93563-2-jhb@FreeBSD.org> <51a3d32c-7ea2-a814-9716-af2fd478b70c@polymtl.ca> From: John Baldwin In-Reply-To: <51a3d32c-7ea2-a814-9716-af2fd478b70c@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646159120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EteEi3fAuWERS4GOXUnrgx92BwI2Yiwi0/xt551QAcU=; b=xtSyIcyEXNboUAJt5CkPFEBJpCnEUbAJk02iorxI+tVlY7at827LyXC9Qi6ULdaxWrj2Oz QH6qI/S2b5Vb8kXbX5mEk/wrjrRGZXfS+0RDX34de+S61+E39dCQap9mSTQ5lnEOGhQhbf AQgZ1AwLtX17/niLNJLuMtfquTAqV4C71ix/wJ70KTFQaJy86gPw7OTNU8idCkZHnpbxbu u6rpPnPN5lX66exyc6oYtQTAMDgaWtSIhXDMtuTjH4bgLc4LcexKQNm8XCn6nCM0onykmG ypk4Bu/AZA9aXSbUYPMgUlVUUguQ5335oeQdBI75TBpVT7JVg/CBoMsMoPXNeQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646159120; a=rsa-sha256; cv=none; b=Te1+nXG8XBHi17e9CjGY8TrR7Cv2uvANhHJPmYOClulJn3k7xEdN/VU2cO+Fp4LsvgeISA 2hpw/4i2Z2tJ2oEpLXH9/fTtgeadg0WdlEiiZzjJ9eNQFTxaiIVvN1AfV8aSy1EX2hQvlJ A1XgDkT9F59oa2wRYHz5ruwnnoYpDZExCdiLkDQ6wLwCCTlGcnPp8yDlK3aq/d3tcd9G4P 71OSsYa5kzaM5qaWh1wJL9aBg0u154WvFJMGNqWwwL1kFQP7HwW6PSA+FS5HMu6Nph77ni dLWPI4pa1k/hsUmVjK8btQHjRy7CZV8IzFKJ8qzXpwYJU/NsIl3kTDU2KaqSkQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 18:25:22 -0000 On 3/1/22 6:22 AM, Simon Marchi wrote: > > > On 2022-02-28 17:35, John Baldwin wrote: >> PT_GETXMMREGS was first added in FreeBSD 6.0 released in November 2005. >> The last FreeBSD release without support was 5.5 released in May 2006. >> --- >> gdb/i386-fbsd-nat.c | 14 -------------- >> 1 file changed, 14 deletions(-) >> >> diff --git a/gdb/i386-fbsd-nat.c b/gdb/i386-fbsd-nat.c >> index 6fb67434a2d..a6ced66250c 100644 >> --- a/gdb/i386-fbsd-nat.c >> +++ b/gdb/i386-fbsd-nat.c >> @@ -42,9 +42,7 @@ class i386_fbsd_nat_target final >> void fetch_registers (struct regcache *, int) override; >> void store_registers (struct regcache *, int) override; >> >> -#if defined(PT_GETXMMREGS) || defined(PT_GETXSTATE_INFO) >> const struct target_desc *read_description () override; >> -#endif >> >> void resume (ptid_t, int, enum gdb_signal) override; >> >> @@ -59,9 +57,7 @@ static i386_fbsd_nat_target the_i386_fbsd_nat_target; >> static size_t xsave_len; >> #endif >> >> -#ifdef HAVE_PT_GETXMMREGS >> static int have_ptrace_xmmregs; > > Is this variable (have_ptrace_xmmregs) still relevant? In other words, > can the PT_GETXMMREGS request legitimately fail? Yes, while the ptrace op always exists, it only works if the running CPU supports SSE (and this is true in i386-bsd-nat.c as well). Granted, the number of systems running modern BSD operating systems on a CPU that doesn't include SSE support (think Pentium or Pentium Pro class CPUs) may be vanishingly small to the point of zero. -- John Baldwin