From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26870 invoked by alias); 6 Oct 2016 01:12:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26850 invoked by uid 89); 6 Oct 2016 01:12:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1533, reader, perfect X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 01:12:52 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 47BD41173A; Thu, 6 Oct 2016 01:12:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u961CnhN002180; Wed, 5 Oct 2016 21:12:50 -0400 Subject: Re: [RFA 08/22] Record minimal symbols directly in reader. To: Simon Marchi , Tom Tromey References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-9-git-send-email-tom@tromey.com> <1bd8bed63872ee567495bf23bc3fe35f@simark.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <50bdd370-5d52-e7e5-54c4-31d32c7161e0@redhat.com> Date: Thu, 06 Oct 2016 01:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1bd8bed63872ee567495bf23bc3fe35f@simark.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00099.txt.bz2 On 10/01/2016 05:29 AM, Simon Marchi wrote: > On 2016-09-27 00:08, Tom Tromey wrote: >> This patch changes minimal symbol creation in two ways. First, it >> removes global variables in favor of members of >> scoped_minimal_symbol_reader. Second, it changes functions like >> prim_record_minimal_symbol to be member functions of >> scoped_minimal_symbol_reader. > > I think this patch (and the previous ones that lead to it) are great. > That's the kind of thing that will make the data flow easier to understand. > > About the naming, it's a bit of a nit, but since it might set the > standard for future classes, I prefer to ask anyway. Does it help in > any way to prefix this class' name with "scoped_"? All C++ > class/objects are "scoped" when statically allocated in a scope, meaning > that they get destroyed when execution goes out of that scope. So it's > not really the property of the class itself that it's scoped, more about > how it's being used. It would be a bit like naming "std::string" -> > "std::scoped_string", since it frees its resources when being destroyed. > "minimal_symbol_reader" sounds like a perfect name for that class, > doesn't it? > > On the other hand, I think scoped_restore is appropriately named, since > it conveys that its primary (and only?) reason to exist is to be used in > conjunction with scopes to do some variable restoring. Seconded. Sorry, hadn't read your reply yet when I sent the previous email. Thanks, Pedro Alves