Re: [PATCH v2 0/5] A few fixes to OpenBSD's native target

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2021-07-27 1:41 p.m., John Baldwin wrote:
> This addresses some feedback from Simon but also adds two additional
> patches that allow some simple fork following to mostly work for me on
> OpenBSD/amd64 6.9.
> 
> The one remaining issue I see is that if I disable detach on fork and
> allow a child process to run to completion then go back and continue
> the parent process, the parent process is killed with a SIGHUP.  I
> think this is probably an issue in OpenBSD's kernel though rather than
> GDB and I don't plan on investigating that further.
> 
> John Baldwin (5):
>   Don't compile x86 debug register support on OpenBSD.
>   x86-bsd-nat: Only define gdb_ptrace when using debug registers.
>   obsd-nat: Various fixes to obsd_nat_target::wait.
>   obsd-nat: Various fixes for fork following.
>   obsd-nat: Report both thread and PID in ::pid_to_str.
> 
>  gdb/configure.nat |   5 +--
>  gdb/obsd-nat.c    | 112 +++++++++++++++-------------------------------
>  gdb/obsd-nat.h    |   2 -
>  gdb/x86-bsd-nat.c |  16 +++----
>  gdb/x86-bsd-nat.h |   9 +++-
>  5 files changed, 53 insertions(+), 91 deletions(-)
> 

Thanks a lot for this, this LGTM, I just noted a few nits to fix.  I'll rebase
my follow-fork patch on top of this once it's merged.

Simon