From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id EC79E3858C27 for ; Thu, 29 Jul 2021 19:16:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC79E3858C27 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 16TJFw01013963 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Jul 2021 15:16:03 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 16TJFw01013963 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4BB611E4A3; Thu, 29 Jul 2021 15:15:58 -0400 (EDT) Subject: Re: [PATCH v2 0/5] A few fixes to OpenBSD's native target To: John Baldwin , gdb-patches@sourceware.org References: <20210727174110.62480-1-jhb@FreeBSD.org> From: Simon Marchi Message-ID: <50d54389-19d5-0a19-3764-a2449a003764@polymtl.ca> Date: Thu, 29 Jul 2021 15:15:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210727174110.62480-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 29 Jul 2021 19:15:58 +0000 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2021 19:16:06 -0000 On 2021-07-27 1:41 p.m., John Baldwin wrote: > This addresses some feedback from Simon but also adds two additional > patches that allow some simple fork following to mostly work for me on > OpenBSD/amd64 6.9. > > The one remaining issue I see is that if I disable detach on fork and > allow a child process to run to completion then go back and continue > the parent process, the parent process is killed with a SIGHUP. I > think this is probably an issue in OpenBSD's kernel though rather than > GDB and I don't plan on investigating that further. > > John Baldwin (5): > Don't compile x86 debug register support on OpenBSD. > x86-bsd-nat: Only define gdb_ptrace when using debug registers. > obsd-nat: Various fixes to obsd_nat_target::wait. > obsd-nat: Various fixes for fork following. > obsd-nat: Report both thread and PID in ::pid_to_str. > > gdb/configure.nat | 5 +-- > gdb/obsd-nat.c | 112 +++++++++++++++------------------------------- > gdb/obsd-nat.h | 2 - > gdb/x86-bsd-nat.c | 16 +++---- > gdb/x86-bsd-nat.h | 9 +++- > 5 files changed, 53 insertions(+), 91 deletions(-) > Thanks a lot for this, this LGTM, I just noted a few nits to fix. I'll rebase my follow-fork patch on top of this once it's merged. Simon