[patch][pr gdbtui/#1275210] Fix cyrillic symbols show in tui

[patch][pr gdbtui/#1275210] Fix cyrillic symbols show in tui

[vaag]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Description: Issue described in bugzilla was fixed in version 8.0-0, but 
reintroduced in latest version.

ChangeLog:

2020-03-12  Vahagn Vardanyan  <vaag@ispras.ru>

         PR gdbtui/1275210
         * tui/tui-winsource.c: Change type from char to unsigned char
         to allow up to 256 bit encoding.
         Use mvwaddstr function to print unicode character in tui


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gdb_git.patch --]
[-- Type: text/x-diff; name=gdb_git.patch, Size: 640 bytes --]

diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index b5ba59e2f7..65814cf3c2 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -87,7 +87,7 @@
     }
 
   int column = 0;
-  char c;
+  unsigned char c;
   do
     {
       int skip_bytes;
@@ -260,8 +260,8 @@
   if (line->is_exec_point)
     tui_set_reverse_mode (handle.get (), true);
 
-  wmove (handle.get (), lineno, TUI_EXECINFO_SIZE);
-  tui_puts (line->line.c_str (), handle.get ());
+  mvwaddstr (handle.get(), lineno, 4,
+               (char *) line->line.c_str ());
   if (line->is_exec_point)
     tui_set_reverse_mode (handle.get (), false);
 

Re: [patch][pr gdbtui/#1275210] Fix cyrillic symbols show in tui

[Simon Marchi]

On 2020-03-28 4:01 p.m., vaag--- via Gdb-patches wrote:
> Description: Issue described in bugzilla was fixed in version 8.0-0, but 
> reintroduced in latest version.

Even though it's described in Bugzilla, please include an analysis of the problem
and of the solution in the commit message.

> 
> ChangeLog:
> 
> 2020-03-12  Vahagn Vardanyan  <vaag@ispras.ru>
> 
>          PR gdbtui/1275210

That PR number is certainly not right.

>          * tui/tui-winsource.c: Change type from char to unsigned char
>          to allow up to 256 bit encoding.
>          Use mvwaddstr function to print unicode character in tui
> 

In the ChangeLog entry, just state the "what" of the change, no need to say
why (that goes into the commit message).  So: change variable type from char
to unsigned char, use mvwaddstr to print the string.  Make sure to finish
with a period, and include the function name like so:

        * tui/tui-winsource.c (tui_copy_source_line): ...

Could you please try to send the v2 of the patch with git-send-email?

Simon