From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 30055385B50F for ; Wed, 30 Nov 2022 17:29:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30055385B50F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4NMmRY66jTz3T7Z; Wed, 30 Nov 2022 17:29:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NMmRY50pwz464v; Wed, 30 Nov 2022 17:29:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669829385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xdXp284Bgn4L5lDZxXOwOyZFA6rLrXQARH23k1xZZ7Q=; b=pu/OTJX4iKMbs+gQT7deI7PMmsgSu4mCDZvbFdKypcZH7XQP81Ygfnq9pDP+rmsQmURgCA iYPk8ZGs2NAoOYNQp9Lxc0JtGsTxuTBIJXIGDD+ZOi3Gh2/44BHDr6eeS62gbVuOnGAbND 1Vhl73oebK0EJgAJtQxvw9qLqVyaQyqaH+EzSBaPXBatcU49sjprP6s7ipcxW9hKJGnhXU 5YJQnBL9kGZyTCvuCXzVsAcEP7aY0RTXCFWpKqEW1LAe1TzDuQYQK1fEzW5cX0A9D3tQ9W 5hFNBoCLsNWX02e0S76vvHMBiUu01bcLrXL27WicFy9vggs89Iow4BzXyLhAGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669829385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xdXp284Bgn4L5lDZxXOwOyZFA6rLrXQARH23k1xZZ7Q=; b=CJKbp7RqL2FU7dJRg9/afAjMrDhY6TWeJmDkFgUZWFSaDEk1qySapKcNvItj3ZKG04hHQQ ikxuMDtybpIzET3t6H3w2mpYvSQbn+4LvpzLPKT+uXBy1MGGcKlhoVZqU7j25yEP39fb9x mP1T1RRx+XK5s+aIXrcmqPtSb9HUN0jB/jLEXCxR/2DWL3ujh6KsaZRfXzJT663DlBYgtW X3rv0M/7HlgwOljzXG/49qPZ9ykTfO7FA8TR90JlUksWD5MYAp/OVKc2P63cIOTWSuxyov m+sp+D5f3awptvWvVlQqAxGQBmA6idcoCQm9PQgDla69fAy0F9eZzvvZvbZFyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669829385; a=rsa-sha256; cv=none; b=tyN9yfDlkHH74lBKwdg6jemUi9RClq2sA3+eURC3Xi6pL+s6wYp9rzSGDn4NT1/QhA3L9a utTCp6Rw2l3B9R36PGnGkjkHtDEH1HBcLPSrtso2eBJPcxS8ArJ7+TiJM3DzaQIYJNxnNo 9+Vuv43TgkXEHuqVb1nqvHV4leia9/Lb5Sk4YgsT9hHa4MbgbbhRKP4Atjmc85w0erz1XO DsG12+CNmEul/TT2nN+o2vyfEkk7iKtWJTTUUmFhFydZvtxfqlrre1v1nAiEDLxSUkAJD/ KPppZzAk0IINyX+Kh23PJzGTKrRJI0YHmkKvOGcNwLCoaHsk2E5AYfayKN1qNA== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NMmRY22dgz159P; Wed, 30 Nov 2022 17:29:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <50ef5c6b-7062-3eac-c739-fa8b442d4288@FreeBSD.org> Date: Wed, 30 Nov 2022 09:29:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 2/3] gdb: break up core_target initialization Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20221129025048.44490-1-simon.marchi@polymtl.ca> <20221129025048.44490-2-simon.marchi@polymtl.ca> <65b25c24-eb7e-65fb-ad96-08665bbcbb67@FreeBSD.org> <2ce82756-688c-3f32-d2f4-2fa450290c5d@polymtl.ca> From: John Baldwin In-Reply-To: <2ce82756-688c-3f32-d2f4-2fa450290c5d@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/29/22 1:53 PM, Simon Marchi wrote: > What about: > > > core_target::core_target () > { > /* Find a first arch based on the BFD. It will possibly be overriden by a > more precise gdbarch in core_target::initialize */ > m_core_gdbarch = gdbarch_from_bfd (core_bfd); > } > > void > core_target::initialize () > { > /* If the initial arch (obtained from the BFD) is able to read a target > description from the core, it could yield a more specific gdbarch. */ > const struct target_desc *tdesc = read_description (); > > Simon This looks good to me, thanks! -- John Baldwin