From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110336 invoked by alias); 26 Aug 2018 18:16:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110095 invoked by uid 89); 26 Aug 2018 18:15:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=Section X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 Aug 2018 18:15:24 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4EB241E52D; Sun, 26 Aug 2018 14:15:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1535307304; bh=Qzd7Ld3xy6cDnb0KfNZNguY9xn/VSU0GrKDeWCOF98g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FrKxUn1O6SMe8sZXeNCs8W99cZqovbfQ5yKeuoKxiWuwKYee3tRxz+O5aaSnGCnIP nWEEYT4D7KfNSku1j98a7VagLmDLvHtQmVZSP3bb7BA1vi7eCOxAXs+1XrZag6TVS9 4RqbSyAj/T86qveSn/THVImHqI01j2m6RzcJZml0= Subject: Re: [PATCH 3/3] GDB: New target s12z To: John Darrington Cc: gdb-patches@sourceware.org References: <20180823173526.26144-1-john@darrington.wattle.id.au> <20180823173526.26144-3-john@darrington.wattle.id.au> <20180826174127.g2qht4j3tqtpxfmz@jocasta.intra> From: Simon Marchi Message-ID: <510acbee-2338-0c20-8e32-8d6ef83be3e1@simark.ca> Date: Sun, 26 Aug 2018 18:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180826174127.g2qht4j3tqtpxfmz@jocasta.intra> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00638.txt.bz2 On 2018-08-26 1:41 p.m., John Darrington wrote: > Hi Simon, > > Thanks for the review. > > On Sun, Aug 26, 2018 at 01:19:29PM -0400, Simon Marchi wrote: > Hi John, > > I did a first pass review and noted a few minor nits. I didn't get too deep in the > frame_id/unwind code because I'm not too familiar with that. > > Pity. I was hoping someone could help me there :{P I just haven't written enough of those to be able to spot bugs off-hand in them. Maybe just one insight, it seems (I'm not sure) that s12z_frame_cache uses the SP value of the current frame (the one for which we compute the id) in the frame id. The usual thing to do (I looked at a few other arches) is to use the same value as the canonical frame address as defined by DWARF (Section 6.4 in DWARF5.pdf), which is the value of the stack pointer just before that frame was created. This is of course not mandatory, but I suppose that adhering to this de facto rule could make things clearer. > Many of your comments and questions stem from the code which I used as a > pattern, so I'm unsure of the answers. But I will find out as best I > can and prepare a new patch within the next few days. > > J' Thanks, Simon