From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from forward502p.mail.yandex.net (forward502p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:121]) by sourceware.org (Postfix) with ESMTPS id E8C5A3858D26 for ; Mon, 7 Nov 2022 13:49:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8C5A3858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=syntacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=syntacore.com Received: from sas8-e2d6e97d76c7.qloud-c.yandex.net (sas8-e2d6e97d76c7.qloud-c.yandex.net [IPv6:2a02:6b8:c1b:2904:0:640:e2d6:e97d]) by forward502p.mail.yandex.net (Yandex) with ESMTP id 7D05BB8149C; Mon, 7 Nov 2022 16:49:30 +0300 (MSK) Received: by sas8-e2d6e97d76c7.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id KLMxsgSuGP-nTgCIm8E; Mon, 07 Nov 2022 16:49:30 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syntacore.com; s=mail; t=1667828970; bh=IlFcxh8jBw/vVH8espFyHx/GY25OLy8SKk4XxSaQv7o=; h=In-Reply-To:From:Date:References:To:Subject:Message-ID; b=mR3h+uoOdZxawKZlH3XT7b412jKQMrzOiXEro5eBOvXUHYXXhGrwOVjx3WgxfEwPy gbJn9EC/jjWDXar1id4gplnBRnrQLi4rVWsbrMwf4ibVvMxcvQPsgrhegPP1NfAZpa H0hAuBOWwjmR3wkN65hSe/plEELUSVd1VJh///Gg= Authentication-Results: sas8-e2d6e97d76c7.qloud-c.yandex.net; dkim=pass header.i=@syntacore.com Message-ID: <5111034b-a2ad-ef85-9498-dd2603122a38@syntacore.com> Date: Mon, 7 Nov 2022 16:49:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/7] [gdb/testsuite] fix test gdb.base/print-file-var.exp for remote execution Content-Language: en-US To: Andrew Burgess , Tom de Vries , gdb-patches@sourceware.org, Andrew Burgess References: <20221025162946.727169-1-ivan.tetyushkin@syntacore.com> <20221025162946.727169-3-ivan.tetyushkin@syntacore.com> <87cz9yc2kz.fsf@redhat.com> From: Ivan Tetyushkin In-Reply-To: <87cz9yc2kz.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Yes, this patch fixes this test. However, it will not fix gdb.base/infcall-exec.exp from the patch 5/7 of this thread. As I can understand now, this test uses absolute paths for checking, but relative paths are used during compilation. We can change regexp itself and check only filename, but this could lead to false positive result. Also, I thought these tests are created to work with absolute paths to ignore solib-search-path. -- Ivan