From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id DA3A3386FC2A for ; Mon, 5 Jul 2021 15:51:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA3A3386FC2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso14421477wmh.4 for ; Mon, 05 Jul 2021 08:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PvQfhFz+Z1fZIZo2ViOzeZpYgNaqFrJGlQE6+kFVWic=; b=LTjru0LVD5WvpGD7OQW9T4R473PXhkdyCZ+RqsQhdh+uaq3Fl+XeHUM7aXN5JpA4Xj gFGlIqUCFYieA8fQPJVf1bKaHJVubg2sfV99MEi4OPyKuz6YqPPV1aP6eESdi0eOXKc6 nTzhOONuTT1MjS4oq3h4Si9bg7zS3nf4pGwkzcZ6Vn3MelC84dr9oG/UkFb87RvqEFCr 1RXQs1mwQVW7H6hlcqiyhALy/UZVm9demPUqhOor9x2v+ZgAU/7Cxhm3POd2iBH18xhC BQIKSAcHfmbnFi+18YIMS+EA2LXTfbHd1pmvC0f6I6ZCn3KvsGsr0cEQO5ob2sC2kYSY y/3w== X-Gm-Message-State: AOAM5336bYibgfhdxtnbEhd3iY2NgqENOB55K1shLLPXTgXyt0Pb8ej4 pqM3Zcd+/3Bzs6R8m2JaktmLMM0OQGsdLQ== X-Google-Smtp-Source: ABdhPJwCnjbMS642pyAjqM0rc2bX+DMvlliW//mBAnm/uemvMsyRr77q+lSrGO1sQ5nzrSC2h3GZwQ== X-Received: by 2002:a05:600c:1d06:: with SMTP id l6mr12571945wms.111.1625500275270; Mon, 05 Jul 2021 08:51:15 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:46bc:d03b:7b3a:2227? ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id 12sm24163341wme.28.2021.07.05.08.51.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jul 2021 08:51:14 -0700 (PDT) Subject: Re: [PATCH 08/11] gdb: optimize check for resumed threads with pending wait status in maybe_set_commit_resumed_all_targets From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210622165704.2404007-1-simon.marchi@polymtl.ca> <20210622165704.2404007-9-simon.marchi@polymtl.ca> Message-ID: <5132fbed-0a84-0ccb-d680-08863ce7146e@palves.net> Date: Mon, 5 Jul 2021 16:51:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210622165704.2404007-9-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2021 15:51:18 -0000 On 2021-06-22 5:57 p.m., Simon Marchi via Gdb-patches wrote: > Consider a test case where many threads (thousands) keep hitting a > breakpoint whose condition evaluates to false. > maybe_set_commit_resumed_all_targets is called at each handled event, > when the scoped_disable_commit_resumed object in fetch_inferior_event is > reset_and_commit-ed. One particularly expensive check in there is > whether the target has at least one resumed thread with a pending wait > status (in which case, we don't want to commit the resumed threads, as > we want to consume this status first). It is currently implemented as > walking all threads of the target. > > Since we now maintain a per-target list of resumed threads with pending > status, we can do this check efficiently, by checking whether that list > is empty or not. > > Add the process_stratum_target::has_resumed_with_pending_wait_status > method for this, and use it in maybe_set_commit_resumed_all_targets. > > gdb/ChangeLog: > > * process-stratum-target.h (class process_stratum_target) > : New. > * infrun.c (maybe_set_commit_resumed_all_targets): Use > has_resumed_with_pending_wait_status. OK.