From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DD791385828C for ; Wed, 10 Aug 2022 19:38:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD791385828C Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 302F41E21F; Wed, 10 Aug 2022 15:38:54 -0400 (EDT) Message-ID: <513cd96d-d945-392f-7d72-769c77f9275b@simark.ca> Date: Wed, 10 Aug 2022 15:38:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] gdb/mi: fix breakpoint script field output Content-Language: en-US To: Simon Marchi , Tom Tromey , Simon Marchi via Gdb-patches References: <20220504121342.1208374-1-simon.marchi@polymtl.ca> <875yls6u6v.fsf@tromey.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 19:38:56 -0000 On 2022-05-26 14:21, Simon Marchi via Gdb-patches wrote: > > > On 2022-05-26 14:10, Tom Tromey wrote: >>>>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> >> Simon> The "script" field, output whenever information about a breakpoint with >> Simon> commands is output, uses wrong MI syntax. >> >> I think this is PR mi/24285. > > Thanks, will add the footer. > >> >> Simon> Fix it, keeping the backwards compatibility by introducing a new MI >> Simon> version (MI4), in exactly the same way as was done when fixing >> Simon> multi-locations breakpoint output in [2]. >> >> Simon> - Add a fix_breakpoint_script_output uiout flag. MI uiouts will use >> Simon> this flag if the version is >= 4. >> >> I was under the impression that MI version 3 was somehow experimental, >> so we didn't need version 4 yet. But maybe the idea is to roll out new >> MI versions with some regularity and just update the version whenever we >> think we've made a breaking change? > > MI3 is the default today, so not experimental. I think it's fine to > bump the version and ship it as soon as we make a fix that is also a > breaking change. There's no reason to hold back fixes. Users (well, > frontends) are supposed to use the interpreter name with the version in > it (mi2, mi3) rather than just "mi", so they don't get bad surprises > when a new MI version is released. And then they can migrate at their > convenience. > > Simon I pushed this. Simon