From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 0BE1D3858D28 for ; Mon, 7 Aug 2023 14:36:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BE1D3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 377EZvIi028902 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 7 Aug 2023 10:36:01 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 377EZvIi028902 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1691418962; bh=Ws+hgj6pDGcZpcLVLCyQACvH0GFgrIeKqVGqxSEq4To=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=k6XTxQWZ/aL2qHMuMgIwo4gCp5RQnGWejfsdLM5NneVylv+IKa2qCWoki3XutYMh8 vQLgoy+DMP2UOKqcMjwa8mER9r4ZmAVz28DATP9gFPRD5x6lghdoL/HdZSVnQNCVcg 789cA6IeJhrjxzt8whBgcXd1qU65cmsbOR/OjGOw= Received: from [127.0.0.1] (unknown [204.48.95.123]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BEA351E028; Mon, 7 Aug 2023 10:35:56 -0400 (EDT) Date: Mon, 07 Aug 2023 10:35:55 -0400 From: Simon Marchi To: Tom de Vries , Tom de Vries via Gdb-patches , gdb-patches@sourceware.org CC: Tom Tromey Subject: Re: [PATCH] [gdb/build] Fix build breaker with -std=c++11 User-Agent: K-9 Mail for Android In-Reply-To: <20230806235915.18746-1-tdevries@suse.de> References: <20230806235915.18746-1-tdevries@suse.de> Message-ID: <51561E9D-24F0-48CB-A563-50F29C2966D9@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 7 Aug 2023 14:35:57 +0000 X-Spam-Status: No, score=-3030.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On August 6, 2023 7:59:15 p=2Em=2E EDT, Tom de Vries via Gdb-patches wrote: >When building with -std=3Dc++11 I run into: >=2E=2E=2E >gdb/dwarf2/cooked-index=2Ec: In member function \ > =E2=80=98void cooked_index::start_writing_index(dwarf2_per_bfd*)=E2=80= =99: >gdb/dwarf2/cooked-index=2Ec:469:10: error: lambda capture initializers on= ly \ > available with -std=3Dc++14 or -std=3Dgnu++14 [-Werror] > ctx =3D std::move (ctx)] () > ^~~ >=2E=2E=2E > >Fix this by capturing a copy instead: >=2E=2E=2E > =3D gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd, ctx] = () >=2E=2E=2E > >Tested on x86_64-linux=2E > >Reported-By: Tom Tromey When we encounter things like this, should we add some greppable TODO comm= ent to record an actionable item for when we switch to a more recent C++ ve= rsion?=20 Simon=20