From: Alan Hayward <Alan.Hayward@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH 1/6] : Commonise various target-descriptions.c functions
Date: Tue, 16 Jan 2018 14:18:00 -0000 [thread overview]
Message-ID: <5159CC81-6EF1-43DC-9C1D-DF85DC51A59D@arm.com> (raw)
In-Reply-To: <CFD4D062-238A-456A-97B1-892FF8D32DF1@arm.com>
> On 16 Jan 2018, at 09:50, Alan Hayward <Alan.Hayward@arm.com> wrote:
>
> This patch simply moves functionality from target-descriptions.c
> to the common files arch/tdesc.c and arch/tdesc.h.
> No functionality is changed.
> This will allow usage by gdbserver.
> The "#ifndef GDBSERVER" around the functions in arch/tdesc.h will be removed
> in the next patch.
>
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 0a4a06b242e0423218648fe77d53fc192456cd2f..386ab5c117ebf34e1ae927b5fe78fd4618012945 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -669,6 +669,7 @@ ALL_TARGET_OBS = \
> arch/arm-get-next-pcs.o \
> arch/arm-linux.o \
> arch/i386.o \
> + arch/tdesc.o \
> arm-bsd-tdep.o \
> arm-fbsd-tdep.o \
> arm-linux-tdep.o \
>
Apologies, just spotted a slight bug. If you build with don’t build with
--enable-targets=all then you’ll get a link error with gdb.
The Makefile.in diff needs changing to the following (instead of the change above)
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -913,6 +912,7 @@ COMMON_SFILES = \
agent.c \
annotate.c \
arch-utils.c \
+ arch/tdesc.c \
auto-load.c \
auxv.c \
ax-gdb.c \
With this, everything builds with and without --enable-targets=all, and all run tests
continue to pass.
Alan.
next prev parent reply other threads:[~2018-01-16 14:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 9:52 [PATCH 0/6] : Remove XML files from gdbserver Alan Hayward
2018-01-16 9:51 ` [PATCH 1/6] : Commonise various target-descriptions.c functions Alan Hayward
2018-01-16 14:18 ` Alan Hayward [this message]
2018-01-19 23:05 ` Yao Qi
2018-01-22 14:06 ` Alan Hayward
2018-01-22 15:47 ` Yao Qi
2018-01-16 9:52 ` [PATCH 2/6]: gdbserver use common tdesc functions Alan Hayward
2018-01-16 9:53 ` [PATCH 3/6] : Update dat files with arch and osabi Alan Hayward
2018-01-19 22:01 ` Yao Qi
2018-01-22 13:22 ` Alan Hayward
2018-01-22 15:28 ` Yao Qi
2018-01-16 9:55 ` [PATCH 6/6]: Remove xml files from gdbserver Alan Hayward
2018-01-19 22:11 ` Yao Qi
2018-01-22 13:23 ` Alan Hayward
2018-01-22 14:52 ` Yao Qi
2018-01-16 9:55 ` [PATCH 5/6] : Remove xml file references from target descriptions Alan Hayward
2018-01-16 9:55 ` [PATCH 4/6]: Create xml " Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5159CC81-6EF1-43DC-9C1D-DF85DC51A59D@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).