Re: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang

[Tom de Vries <tdevries@suse.de>]

On 7/3/20 1:20 PM, Pedro Alves wrote:
> On 7/3/20 10:21 AM, Gary Benson wrote:
>> Tom de Vries wrote:
>>> On 6/29/20 2:32 PM, Pedro Alves wrote:
> 
>>>> I would suggest filing a bug with clang, to confirm whether
>>>> this is intentional, or whether they see it as a bug.  I would
>>>> think it is a bug, but I'm not sure.  If indeed a bug, we would
>>>> XFAIL the test.
>>>
>>> I've filed https://bugs.llvm.org/show_bug.cgi?id=46514 .
>>>
>>> Thanks,
>>> - Tom
>>
>> Thank for filing it Tom.
> 
> So the conclusion seems to be that the testcase should be using
> -fstandalone-debug?
> 
> Except, I tried it here, and it doesn't seem to work:
> 

It is my understanding that -fstandalone-debug should be used for clang,
but that is doesn't work atm, which is a problem in clang/llvm that is
tracked in the PR.

Thanks,
- Tom

> ~~~~~~~~~~~~~~~~
> From 792aa03ab3325fe7cfcfeb51e765e81da2fbbfaf Mon Sep 17 00:00:00 2001
> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 3 Jul 2020 12:12:19 +0100
> Subject: [PATCH] standalone
> 
> ---
>  gdb/testsuite/gdb.base/psym-external-decl.exp | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.base/psym-external-decl.exp b/gdb/testsuite/gdb.base/psym-external-decl.exp
> index d0388d5655e..faff3234bb5 100644
> --- a/gdb/testsuite/gdb.base/psym-external-decl.exp
> +++ b/gdb/testsuite/gdb.base/psym-external-decl.exp
> @@ -15,17 +15,18 @@
>  
>  standard_testfile .c psym-external-decl-2.c
>  
> +set srcfiles [list $srcfile $srcfile2]
> +set options {debug}
> +
>  get_compiler_info
>  if { [test_compiler_info "clang-*"] } {
> -    return -1
> +    lappend options additional_flags=-fstandalone-debug
>  }
>  
> -set srcfiles [list $srcfile $srcfile2]
> -
>  if { [build_executable_from_specs \
>  	  "failed to prepare" \
>  	  $testfile [list] \
> -	  $srcfile [list debug] \
> +	  $srcfile $options \
>  	  $srcfile2 [list]] == -1 } {
>      return -1
>  }
> 
> base-commit: c2ecccb33c307faa21f4d2f47348e7346b032d94
>