From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D9C2C3858D20 for ; Tue, 1 Mar 2022 14:22:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9C2C3858D20 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 221EMYSL023603 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 1 Mar 2022 09:22:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 221EMYSL023603 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9AD0D1EA69; Tue, 1 Mar 2022 09:22:34 -0500 (EST) Message-ID: <51a3d32c-7ea2-a814-9716-af2fd478b70c@polymtl.ca> Date: Tue, 1 Mar 2022 09:22:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/3] i386-fbsd-nat: Assume PT_GETXMMREGS is present. Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org References: <20220228223539.93563-1-jhb@FreeBSD.org> <20220228223539.93563-2-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20220228223539.93563-2-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 1 Mar 2022 14:22:34 +0000 X-Spam-Status: No, score=-3039.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 14:22:50 -0000 On 2022-02-28 17:35, John Baldwin wrote: > PT_GETXMMREGS was first added in FreeBSD 6.0 released in November 2005. > The last FreeBSD release without support was 5.5 released in May 2006. > --- > gdb/i386-fbsd-nat.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/gdb/i386-fbsd-nat.c b/gdb/i386-fbsd-nat.c > index 6fb67434a2d..a6ced66250c 100644 > --- a/gdb/i386-fbsd-nat.c > +++ b/gdb/i386-fbsd-nat.c > @@ -42,9 +42,7 @@ class i386_fbsd_nat_target final > void fetch_registers (struct regcache *, int) override; > void store_registers (struct regcache *, int) override; > > -#if defined(PT_GETXMMREGS) || defined(PT_GETXSTATE_INFO) > const struct target_desc *read_description () override; > -#endif > > void resume (ptid_t, int, enum gdb_signal) override; > > @@ -59,9 +57,7 @@ static i386_fbsd_nat_target the_i386_fbsd_nat_target; > static size_t xsave_len; > #endif > > -#ifdef HAVE_PT_GETXMMREGS > static int have_ptrace_xmmregs; Is this variable (have_ptrace_xmmregs) still relevant? In other words, can the PT_GETXMMREGS request legitimately fail? Simon