From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28904 invoked by alias); 8 Aug 2013 09:18:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28873 invoked by uid 89); 8 Aug 2013 09:18:30 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 08 Aug 2013 09:18:29 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1V7MMP-0003aS-2B from Yao_Qi@mentor.com ; Thu, 08 Aug 2013 02:18:21 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 8 Aug 2013 02:18:20 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Thu, 8 Aug 2013 02:18:20 -0700 Message-ID: <5203622A.5010606@codesourcery.com> Date: Thu, 08 Aug 2013 09:18:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pierre Muller CC: Subject: Re: [RFA] Avoid unlimited height on mingw built GDB's. References: <001c01ce9412$2c438df0$84caa9d0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001c01ce9412$2c438df0$84caa9d0$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00238.txt.bz2 On 08/08/2013 04:35 PM, Pierre Muller wrote: > 2013-08-08 Pierre Muller > > * src/gdb/utils.c (init_page_info): Only call tgetnum function Remove "src/gdb/". > if rl_get_screen_size did not return useful values. > > > Index: src/gdb/utils.c > =================================================================== > RCS file: /cvs/src/src/gdb/utils.c,v > retrieving revision 1.305 > diff -u -p -r1.305 utils.c > --- src/gdb/utils.c 1 Aug 2013 09:09:58 -0000 1.305 > +++ src/gdb/utils.c 7 Aug 2013 12:56:49 -0000 > @@ -1660,12 +1660,16 @@ init_page_info (void) > lines_per_page = rows; > chars_per_line = cols; It looks suspicious to me that we assign a signed integer to a unsigned one, but it is not related to this patch. I don't have comments on this patch. This issue was discussed in 2012 here http://sourceware.org/ml/gdb-patches/2012-10/msg00282.html and Eli suggested that we can get rid of windows-termcap.c and use mingw ncurses build for gdb, so we don't want to pursue this way? -- Yao (齐尧)