From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18053 invoked by alias); 13 Aug 2013 18:09:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17963 invoked by uid 89); 13 Aug 2013 18:09:37 -0000 X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 13 Aug 2013 18:09:37 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7DI9ZDs015063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Aug 2013 14:09:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7DI9XFe008010; Tue, 13 Aug 2013 14:09:34 -0400 Message-ID: <520A765D.8000903@redhat.com> Date: Tue, 13 Aug 2013 18:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Muhammad Bilal CC: "gdb-patches@sourceware.org" , jan.kratochvil@redhat.com Subject: Re: [PATCH 2/5] [PR gdb/15224] Fix incorrectly touched history file even if no commands get, added to it References: <52032A42.5010408@codesourcery.com> In-Reply-To: <52032A42.5010408@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00357.txt.bz2 On 08/08/2013 06:18 AM, Muhammad Bilal wrote: > History save should be perform on interactive debugging. > so, using the input_from_terminal_p fixed this problem. > > > 2013-08-08 Muhammad Bilal > > PR gdb/15224 (Just like PR cli/15715, all these bugs should each their own different number, and then 15224 should be made dependent of them. This patch is not about saving history by default, although it is a necessary dependency for doing that.) > * top.c (quit_force): Fixed incorrectly touching history file > to use input_from_terminal_p. "Fixed incorrectly" is a "why" and ambiguous (and sometimes, wrong). Say: * top.c (quit_force): Skip writing history file if input is not from terminal. Otherwise OK. Thanks, -- Pedro Alves