From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3E3D1385802B for ; Thu, 31 Dec 2020 04:54:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3E3D1385802B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BV4rsqH015888 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Dec 2020 23:53:59 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BV4rsqH015888 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A0B631E99A; Wed, 30 Dec 2020 23:53:54 -0500 (EST) Subject: Re: [PATCH 4/4] Fix raw-frame-arguments in combination with frame-filters To: Hannes Domani , gdb-patches@sourceware.org References: <20201229170227.821-1-ssbssa@yahoo.de> <20201229170227.821-4-ssbssa@yahoo.de> From: Simon Marchi Message-ID: <52196aba-3452-5ff2-e2a0-14b0c554faa3@polymtl.ca> Date: Wed, 30 Dec 2020 23:53:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201229170227.821-4-ssbssa@yahoo.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 31 Dec 2020 04:53:54 +0000 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2020 04:54:01 -0000 On 2020-12-29 12:02 p.m., Hannes Domani via Gdb-patches wrote: > Currently, if frame-filters are active, raw-values is used instead of > raw-frame-arguments to decide if a pretty-printer should be invoked for > frame arguments in a backtrace. > > This adds the PRINT_RAW_FRAME_ARGUMENTS flag to frame_filter_flag which is > then used in the frame-filter to override the raw flag in enumerate_args. I'm not sure I understand the problem, but I have a small comment for the test case: > diff --git a/gdb/testsuite/gdb.python/py-frame-args.exp b/gdb/testsuite/gdb.python/py-frame-args.exp > index fd9c1f4342..7c621e1302 100644 > --- a/gdb/testsuite/gdb.python/py-frame-args.exp > +++ b/gdb/testsuite/gdb.python/py-frame-args.exp > @@ -34,6 +34,28 @@ gdb_test_no_output "source ${remote_python_file}" "load python file" > gdb_breakpoint [gdb_get_line_number "break-here"] > gdb_continue_to_breakpoint "break-here" ".* break-here .*" > > +# Test raw-frame-arguments on backtrace with and without frame-filter > +foreach filtered [list "enable" "disable"] { > + gdb_test_no_output "$filtered frame-filter global BasicFrameFilter" > + > + gdb_test "bt 1" \ > + ".*foo \\(x=42, ss=super struct = {\[.\]{3}}\\).*" \ > + "bt frame-filter=$filtered,pretty" > + > + gdb_test "bt -raw-frame-arguments on 1" \ > + ".*foo \\(x=42, ss=\[.\]{3}\\).*" \ > + "bt frame-filter=$filtered,raw" > + > + # "set print raw-values" should not affect frame arguments > + gdb_test_no_output "set print raw-values on" \ > + "raw-values-on,frame-filter=$filtered" > + gdb_test "bt 1" \ > + ".*foo \\(x=42, ss=super struct = {\[.\]{3}}\\).*" \ > + "bt frame-filter=$filtered,pretty,raw-values" > + gdb_test_no_output "set print raw-values off" \ > + "raw-values-off,frame-filter=$filtered" > +} You can use foreach_with_prefix, that will ensure test names are unique without having to include frame-filter=$filtered in each test name. Something like this: # Test raw-frame-arguments on backtrace with and without frame-filter foreach_with_prefix filtered {enable disable} { gdb_test_no_output "$filtered frame-filter global BasicFrameFilter" gdb_test "bt 1" \ ".*foo \\(x=42, ss=super struct = {\[.\]{3}}\\).*" \ "bt pretty" gdb_test "bt -raw-frame-arguments on 1" \ ".*foo \\(x=42, ss=\[.\]{3}\\).*" \ "bt raw" # "set print raw-values" should not affect frame arguments gdb_test_no_output "set print raw-values on" gdb_test "bt 1" \ ".*foo \\(x=42, ss=super struct = {\[.\]{3}}\\).*" \ "bt pretty,raw-values" gdb_test_no_output "set print raw-values off" } Simon