From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7F2553858415 for ; Mon, 7 Nov 2022 18:16:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F2553858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id ED3C21E0CB; Mon, 7 Nov 2022 13:16:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1667845015; bh=gnju9kA4nWgyV1i1gBOvUa/qKraePa+KUpWzgqOPYYo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=OD2vbu9O+A3i3SccNNCbJeMfXhH7GAgbLKwDdFZ3gUqzo26Ot9BHtAd8wOnuejJrq pvbKZLmOMcfrC1qWGuotPTn3Emqn72h+Oeo9pKBgaYwbgnnSv4rUDgaUfPBUVaKw// ut9XQ6/BKwnzsUNvK+SDhVuG90a/queMf9mxsAsI= Message-ID: <5227d2fb-26fa-907f-de4a-3cdcb47ae813@simark.ca> Date: Mon, 7 Nov 2022 13:16:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] Silence libtool during link Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20221107181353.68359-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20221107181353.68359-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/7/22 13:13, Tom Tromey via Gdb-patches wrote: > The switch to linking with libtool now shows a very long link line > even when V=0. This patch arranges to silence libtool in this > situation. > --- > gdb/Makefile.in | 2 +- > gdb/silent-rules.mk | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 522fc20bccd..0f5df2ccb7b 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -148,7 +148,7 @@ LIBTOOL = @LIBTOOL@ > # Set this up with gcc if you have gnu ld and the loader will print out > # line numbers for undefined references. > #CC_LD = g++ -static > -CC_LD = $(LIBTOOL) --mode=link $(CXX) $(CXX_DIALECT) > +CC_LD = $(LIBTOOL) $(SILENT_FLAG) --mode=link $(CXX) $(CXX_DIALECT) > > # Where is our "include" directory? Typically $(srcdir)/../include. > # This is essentially the header file directory for the library > diff --git a/gdb/silent-rules.mk b/gdb/silent-rules.mk > index c2c43481296..36791f6683f 100644 > --- a/gdb/silent-rules.mk > +++ b/gdb/silent-rules.mk > @@ -18,4 +18,6 @@ ECHO_LEX = @echo " LEX $@"; > ECHO_AR = @echo " AR $@"; > ECHO_RANLIB = @echo " RANLIB $@"; > SILENCE = @ > +# Silence libtool. > +SILENT_FLAG = --silent > endif Oops, I had not noticed that during review. LGTM: Approved-By: Simon Marchi Simon