From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id 024973858C54 for ; Tue, 17 Oct 2023 15:23:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 024973858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 024973858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697556213; cv=none; b=daGF0OF8P0FBAO4IP1stIYaS9zFWXiwm63ilHeF59z+3q3W3LDX8Q/Fs6ruVdotkjzPo9Xde8M1lBW4yiAJkfqh9/PqiTUlXrugDUI8soJjc/GJHq4iJ+eMZqKCNiXJs9Li2Oef6mbNIYFhS4xBwAYHaDsKXy5eyFtwloKErKac= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697556213; c=relaxed/simple; bh=C8wzSwxWXXPE4WZbq9SoKvNyfuC5q6asixCPrtAuHik=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=MqXKe7S0fCji4J9TSNJuBTxhBdBusNyna2XUfUcl2f+/kmRn64Kr0SxIsPQNz9b/Pq8liJYGP3sQfWpHRBZhJGwQaBOmX9u3BdcnVclFRthz2KlAu8Ja/nDWxG3P3GtgHpIxA1t1Y+Q3k07DAqdOwj4bCr0Ce7JOLxhPAx9VLQo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-323ef9a8b59so5490116f8f.3 for ; Tue, 17 Oct 2023 08:23:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697556210; x=1698161010; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R8NX8OJKA0zc1tyjJmWg6SWDkrGYtRRzXriRoJTg1RM=; b=TCFZscUdyqKRIow3Jg5pPtVMV0qT4gHXN4fBJJv+kgTQAy37cT24OUTZY2FUi5GWYA 32GkbJcMNNgIUd51I/YXjyzwzG0hWJXIhi/DoYsXAkwcYKyFAMaCusMCisjpIIFqqvgH OE2hs9UBd8JZWKLSpOrE27ZpCgeRwHQ5mKBcejhEE3Air6uvXhE1a4nrjiovG0I3lLsk wCFgCKyiV28IqZVq4T/hMF/Abs/gMzTOD0n4ucrekjYJR7z+YOb1n4hExhpKKiWJL5tM OhhQytl2/bjHe22SD2e8pOEsuaN1XtEjtyNtFzkNAVjOOxobsS+f8F+AzNv+pmvF1j2u gMyg== X-Gm-Message-State: AOJu0YxAND2W/QL1W/JZi5y/dBibc3KWoRafPHXi7oXJNp5djmzd5oDL ztNU1Nfl1S58w1/vyFkgAcU= X-Google-Smtp-Source: AGHT+IFmydsk2rw/NZVfSUOlWTx7L0oPk68VauWygb2+53bqbp7j3DMT6oITEQmY35tyz+Tpw45kfg== X-Received: by 2002:adf:9d90:0:b0:32d:8992:94c4 with SMTP id p16-20020adf9d90000000b0032d899294c4mr2385136wre.10.1697556209479; Tue, 17 Oct 2023 08:23:29 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:5aaf:ade2:476b:3ff2? ([2001:8a0:f939:d200:5aaf:ade2:476b:3ff2]) by smtp.gmail.com with ESMTPSA id k7-20020a5d5187000000b0032da8fb0d05sm1883996wrv.110.2023.10.17.08.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 08:23:28 -0700 (PDT) Message-ID: <523ea38d-d363-4ee7-8506-304cdf979f6e@palves.net> Date: Tue, 17 Oct 2023 16:23:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/24] gdb: make solib-rocm not use so_list internally Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-14-simon.marchi@efficios.com> From: Pedro Alves In-Reply-To: <20231010204213.111285-14-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-10 21:40, Simon Marchi wrote: > --- a/gdb/solib-rocm.c > +++ b/gdb/solib-rocm.c > @@ -126,14 +126,26 @@ rocm_solib_fd_cache::close (int fd, fileio_error *target_errno) > > /* ROCm-specific inferior data. */ > > +struct rocm_so > +{ > + rocm_so (const char *name, std::string unique_name, lm_info_svr4_up lm_info) > + : name (name), > + unique_name (std::move(unique_name)), Space after "move".