From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105889-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21291 invoked by alias); 1 Oct 2013 01:19:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 21282 invoked by uid 89); 1 Oct 2013 01:19:23 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 01:19:23 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r911JJfU020874	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 30 Sep 2013 21:19:19 -0400
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r911JIA0005683	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Mon, 30 Sep 2013 21:19:18 -0400
Message-ID: <524A2316.8020607@redhat.com>
Date: Tue, 01 Oct 2013 01:19:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
CC: "'gdb-patches'" <gdb-patches@sourceware.org>
Subject: Re: [RFC 2/6] Avoid missing char before incomplete sequence in wchar_iterate.
References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <002f01cebaf2$aac80410$00580c30$@muller@ics-cnrs.unistra.fr>
In-Reply-To: <002f01cebaf2$aac80410$00580c30$@muller@ics-cnrs.unistra.fr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2013-10/txt/msg00002.txt.bz2

On 09/26/2013 12:57 PM, Pierre Muller wrote:
>      If charset is set to UTF-8
> p "ABCD\340"
> will output
>    "ABC" <incomplete sequence \340>
>
>    Note the missing character 'D'.
>
>    This patch solves the issue by checking also for EINVAL
> if character have been converted.

This looks okay to me, but it needs a test (and a maintainer to approve).

Keith