From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22698 invoked by alias); 1 Oct 2013 01:19:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22686 invoked by uid 89); 1 Oct 2013 01:19:43 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 01:19:43 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r911Jce5000377 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Sep 2013 21:19:38 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r911JbkC022804 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 30 Sep 2013 21:19:38 -0400 Message-ID: <524A2329.3030706@redhat.com> Date: Tue, 01 Oct 2013 01:19:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pierre Muller CC: "'gdb-patches'" Subject: Re: [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts. References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <003b01cebaf3$a2d79620$e886c260$@muller@ics-cnrs.unistra.fr> In-Reply-To: <003b01cebaf3$a2d79620$e886c260$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00004.txt.bz2 Hi, Pierre, On 09/26/2013 01:04 PM, Pierre Muller wrote: > The first part has to do with the fact that GDB prints > the memory address and the closest symbol while the test > doesn't cope for this. > I simply fixed this by setting/unsetting printing of > addresses and symbols at specific locations. Can you provide an example? I notice no difference on linux with/without those options set. Is the output really different on MinGW? [I wouldn't have guessed that they are.] In any case, this bit seems harmless enough. If you say it fixes problems, I believe you, and I'm all for it! > The last errors were generated by the use of Ctrl-V > to avoid problems with possible association of @ to kill command. > mingw GDB doesn't handle this Ctrl-V, so I conditionally removed it for > *-*-mingw* hosts. This isn't so much a question for you specifically, but I thought I'd throw this out to the greater wisdom of the list. I searched around the test suite and found a bunch of places where this character is used without the ^V hack. Is it (still) necessary at all? Perhaps we can just get rid of it entirely? Otherwise, given the harmless nature of the changes, I'd recommend that a maintainer approve this. Keith