From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16407 invoked by alias); 8 Oct 2013 16:13:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16390 invoked by uid 89); 8 Oct 2013 16:13:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Oct 2013 16:13:43 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r98GDeHp015111 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Oct 2013 12:13:40 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r98GDdH0007671; Tue, 8 Oct 2013 12:13:39 -0400 Message-ID: <52542F32.2060908@redhat.com> Date: Tue, 08 Oct 2013 16:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Jose E. Marchesi" CC: gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: adjust line number in commands.exp References: <8761t9m8mo.fsf@oracle.com> <5252DE0D.4060106@redhat.com> <87zjqlknes.fsf@oracle.com> In-Reply-To: <87zjqlknes.fsf@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00229.txt.bz2 On 10/07/2013 06:20 PM, Jose E. Marchesi wrote: > > > Tested in both sparc64-*-linux-gnu and x86_64-*-linux-gnu. > > > > 2013-10-07 Jose E. Marchesi > > > > * gdb.base/commands.exp (watchpoint_command_test): Adjust line > > number in run.c with the end of scope of the block containing > > local_var. > > This is PR 15986. Could you make this use gdb_get_line_number? > > Something like this? Yes. This is OK, thanks. For future patches I will search the bugzilla first :) :-) -- Pedro Alves