From: Pedro Alves <palves@redhat.com>
To: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Mirza, Taimoor" <Taimoor_Mirza@mentor.com>
Subject: Re: [patch] Disassembly improvements
Date: Thu, 10 Oct 2013 14:52:00 -0000 [thread overview]
Message-ID: <5256BF1B.9010202@redhat.com> (raw)
In-Reply-To: <EB3B29AD43CA924DA27099BC85192376E0705237@EU-MBX-03.mgc.mentorg.com>
On 10/10/2013 02:57 PM, Abid, Hafiz wrote:
>> >
>> > Hmm, this seems to miss making sure LEN doesn't read beyond the original
>> > requested memory range. It'd be good to add that.
> Changed to following line which should take care of this.
> unsigned int length = min (len, info->buffer_length);
But it seems to me that will just disable the optimization for
buffer line > 1.
LEN here I think will the disassembler considers to be the maximum
length of an instruction for the arquitecture it is disassembling.
We want to read _more_ than that from memory in one go, otherwise, we'll
not be buffering anything. What we do not want, is for that over
fetching to read beyond the range that was passed to gdb_disassembly.
I think we'll need to derive from "struct disassemble_info",
and add the original range to that new struct, or record that info
directly in "struct disassemble_info", which is in include/dis-asm.h.
--
Pedro Alves
next prev parent reply other threads:[~2013-10-10 14:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 13:14 Abid, Hafiz
2013-10-10 13:34 ` Pedro Alves
2013-10-10 13:57 ` Abid, Hafiz
2013-10-10 14:52 ` Pedro Alves [this message]
2013-10-10 15:13 ` Pedro Alves
2013-10-11 16:45 ` Abid, Hafiz
2013-10-11 21:12 ` Pedro Alves
2013-10-11 21:34 ` Doug Evans
2013-10-14 9:37 ` Abid, Hafiz
2013-10-14 14:42 ` Pedro Alves
2013-10-16 1:16 ` Doug Evans
2013-10-16 7:53 ` Yao Qi
2013-10-16 12:08 ` Pedro Alves
2013-10-16 13:23 ` Yao Qi
2013-10-18 10:24 ` Yao Qi
2013-10-18 18:25 ` Pedro Alves
2013-10-19 1:55 ` Yao Qi
2013-10-25 7:56 ` Doug Evans
2013-10-16 12:02 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5256BF1B.9010202@redhat.com \
--to=palves@redhat.com \
--cc=Hafiz_Abid@mentor.com \
--cc=Taimoor_Mirza@mentor.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).