From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id AC3A738493EA for ; Sun, 4 Dec 2022 16:45:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC3A738493EA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id k7so8804860pll.6 for ; Sun, 04 Dec 2022 08:45:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=lVIIqe14/vbqQ/N2qeVwWyB2pgLrQeMNsrKMhVGJXgQ=; b=fVKqe0D96JnEnfnghVNdkGBQP4KfZYcKOHA3OqBw5tLWMJpmxGMcT9d75My9s4/ZWT NklHwaGTtP5SoeZgRkuYxNefgyxULlqepUYaUU/MjSMPtVH0dARBI1WaVualFzNx3K7q y5+Z2CG7ADFKENU0w9sMLsN1058b8bvEOQFnhSl9xw15T0LdPoUaWiNfky1hQVeL+6ke +oEBw8+i0mJHtjPq5fr/mxGcNf/d7/elvmN7xWw3cmJCgKsLDaNso+LTsSiR9LLqyVKi jUl4r3PH1p2Jnm3Z+zjEeILQthy0uaweiiOANKjyDpLhzFpzNgHkmiwpPtvZA0O2Gd3A bKvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lVIIqe14/vbqQ/N2qeVwWyB2pgLrQeMNsrKMhVGJXgQ=; b=B7aG4Ps0dxOhmRBJNLNsCjfpBxSE0nsC2iPHHkA597Hdi8WAJk6jH0ZAkJq4qBMjA6 1v0yPG3QuYN6vnA3ReV3oDZo1ygnhkPGlzNKPQ0xVXArZXZRinA2TT64s/Af603vrI3P YtE/14mri8lweXDXJSwG4y3zviD2qI1e18ImDJ2a5UaoL+llllTQHCd6V8juejXL2MKx gkBgvAmF3p1UuwkhcanbngF6HSlyhXgD8w7vxQTEwmQFqqG8jghVUlSzPptHjh7pgQkg QZaaXnXe1aB4EwSCAuM6OoEe0ee2LrdlwVlykVXgqso+3Ls9QelRzEHf0gsNOsnOTn5X hPww== X-Gm-Message-State: ANoB5pkOtTsIgYSgYstLUn02uA4KCK5pQp7hMczD6xrr/e7VM4MFs7Sv u/p7mWpQvP2BwHL48Am6CzcenGW1qPQ= X-Google-Smtp-Source: AA0mqf689DEy5QfRYufA8NbJ8fzgJqPnSpVJ3VGmhUrX8Hz4k4JsnBRZlgDTVgDn68oJ9AaXCXcZ/w== X-Received: by 2002:a17:90a:4313:b0:212:e24e:16b3 with SMTP id q19-20020a17090a431300b00212e24e16b3mr90055681pjg.69.1670172321667; Sun, 04 Dec 2022 08:45:21 -0800 (PST) Received: from [10.14.0.2] ([45.144.227.14]) by smtp.gmail.com with ESMTPSA id r16-20020a63fc50000000b00477bdc1d5d5sm7004879pgk.6.2022.12.04.08.45.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Dec 2022 08:45:20 -0800 (PST) Message-ID: <525832fc-7e9b-ab51-25b0-62df8a3b7c2d@gmail.com> Date: Mon, 5 Dec 2022 00:45:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: [PING^4] [PATCH v2] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop From: Johnson Sun To: BrunoLarsen , gdb-patches@sourceware.org References: <20220923060027.78902-1-j3.soon777@gmail.com> <20221020182456.2701-1-j3.soon777@gmail.com> <2e4ab20c-30f4-e6cd-69ec-729b1d74a921@gmail.com> Content-Language: en-US In-Reply-To: <2e4ab20c-30f4-e6cd-69ec-729b1d74a921@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping for: . Johnson On 11/25/2022 11:10 PM, Johnson Sun wrote: > Ping for: > . > > Johnson > > On 11/18/2022 8:14 PM, JohnsonSun wrote: >> Ping for: >> . >> >> Johnson >> >> On 10/21/2022 2:24 AM, Johnson Sun wrote: >>> In 2014, the function `gdbpy_should_stop' has been replaced with >>> `gdbpy_breakpoint_cond_says_stop' >>> >>> This replaces `gdbpy_should_stop' with >>> `gdbpy_breakpoint_cond_says_stop' in the >>> comments. >>> >>> Since `gdbpy_should_stop' has been renamed as noted in >>> `gdb/ChangeLog-2014': >>> >>>     * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed >>>     from gdbpy_should_stop.  Change result type to enum scr_bp_stop. >>> --- >>>   gdb/python/py-finishbreakpoint.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/gdb/python/py-finishbreakpoint.c >>> b/gdb/python/py-finishbreakpoint.c >>> index c80096f6810..dcf86317779 100644 >>> --- a/gdb/python/py-finishbreakpoint.c >>> +++ b/gdb/python/py-finishbreakpoint.c >>> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self) >>>     Py_TYPE (self)->tp_free (self); >>>   } >>>   -/* Triggered when gdbpy_should_stop is about to execute the >>> `stop' callback >>> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to >>> execute the `stop' callback >>>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and >>> cache the >>>      `return_value', if possible.  */ >>>   @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct >>> gdbpy_breakpoint_object *bp_obj) >>>       } >>>   } >>>   -/* Triggered when gdbpy_should_stop has triggered the `stop' >>> callback >>> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the >>> `stop' callback >>>      of the gdb.FinishBreakpoint object BP_OBJ.  */ >>>     void >>