From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8596 invoked by alias); 14 Oct 2013 08:49:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8493 invoked by uid 89); 14 Oct 2013 08:49:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2013 08:49:24 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9E8nMqX001679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Oct 2013 04:49:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9E8nL1Z001580; Mon, 14 Oct 2013 04:49:21 -0400 Message-ID: <525BB010.3050105@redhat.com> Date: Mon, 14 Oct 2013 08:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ondrej Oprala CC: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 05/18] poison "private" References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-6-git-send-email-ooprala@redhat.com> In-Reply-To: <1381339053-14519-6-git-send-email-ooprala@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00425.txt.bz2 On 10/09/2013 06:17 PM, Ondrej Oprala wrote: > /* Private data used by the target vector implementation. */ > - struct private_thread_info *private; > + struct private_thread_info *private_data; > > /* Function that is called to free PRIVATE. If this is NULL, then > xfree will be called on PRIVATE. */ These PRIVATE references should also be updated. The field that comment is describing is: /* Function that is called to free PRIVATE. If this is NULL, then xfree will be called on PRIVATE. */ void (*private_dtor) (struct private_thread_info *); I think it should be renamed accordingly too. BTW, I think it'd be much clearer if we renamed away all this 'private' wording, like, say: struct private_thread_info -> struct target_thread_info and: struct target_thread_info *target_data; void (*target_data_dtor) (struct target_thread_info *); -- Pedro Alves