From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: Pedro Alves <palves@redhat.com>,
"Abid, Hafiz" <Hafiz_Abid@mentor.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Mirza, Taimoor" <Taimoor_Mirza@mentor.com>
Subject: Re: [patch] Disassembly improvements
Date: Wed, 16 Oct 2013 07:53:00 -0000 [thread overview]
Message-ID: <525E4596.70503@codesourcery.com> (raw)
In-Reply-To: <21085.59640.697075.435874@ruffy.mtv.corp.google.com>
On 10/16/2013 09:16 AM, Doug Evans wrote:
> > If I were to try one, I think it would be along the lines of
> > a new TARGET_OBJECT_DISASM_MEMORY, and somehow pass more info down
> > the target_xfer interface so that the the core memory reading code
> > handles the caching. Probably, that'd be done with a new pair of
> > 'begin/end code caching' functions that would be called at the
> > appropriate places. The new code in dis_asm_read_memory would
> > then be pushed to target.c, close to where stack cache is handled.
>
> How hard would it be to do that now?
AFAICS, it is not hard. We've already had TARGET_OBJECT_STACK_MEMORY,
so it is straightforward to add TARGET_OBJECT_CODE_MEMORY, and disas and
skip_prologue can use it.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-10-16 7:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 13:14 Abid, Hafiz
2013-10-10 13:34 ` Pedro Alves
2013-10-10 13:57 ` Abid, Hafiz
2013-10-10 14:52 ` Pedro Alves
2013-10-10 15:13 ` Pedro Alves
2013-10-11 16:45 ` Abid, Hafiz
2013-10-11 21:12 ` Pedro Alves
2013-10-11 21:34 ` Doug Evans
2013-10-14 9:37 ` Abid, Hafiz
2013-10-14 14:42 ` Pedro Alves
2013-10-16 1:16 ` Doug Evans
2013-10-16 7:53 ` Yao Qi [this message]
2013-10-16 12:08 ` Pedro Alves
2013-10-16 13:23 ` Yao Qi
2013-10-18 10:24 ` Yao Qi
2013-10-18 18:25 ` Pedro Alves
2013-10-19 1:55 ` Yao Qi
2013-10-25 7:56 ` Doug Evans
2013-10-16 12:02 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E4596.70503@codesourcery.com \
--to=yao@codesourcery.com \
--cc=Hafiz_Abid@mentor.com \
--cc=Taimoor_Mirza@mentor.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).