From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9319 invoked by alias); 16 Oct 2013 07:53:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9305 invoked by uid 89); 16 Oct 2013 07:53:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2013 07:53:15 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VWLup-00071i-7V from Yao_Qi@mentor.com ; Wed, 16 Oct 2013 00:53:11 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 16 Oct 2013 00:53:11 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Wed, 16 Oct 2013 00:53:10 -0700 Message-ID: <525E4596.70503@codesourcery.com> Date: Wed, 16 Oct 2013 07:53:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Doug Evans CC: Pedro Alves , "Abid, Hafiz" , "gdb-patches@sourceware.org" , "Mirza, Taimoor" Subject: Re: [patch] Disassembly improvements References: <525C02E5.2060601@redhat.com> <21085.59640.697075.435874@ruffy.mtv.corp.google.com> In-Reply-To: <21085.59640.697075.435874@ruffy.mtv.corp.google.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00475.txt.bz2 On 10/16/2013 09:16 AM, Doug Evans wrote: > > If I were to try one, I think it would be along the lines of > > a new TARGET_OBJECT_DISASM_MEMORY, and somehow pass more info down > > the target_xfer interface so that the the core memory reading code > > handles the caching. Probably, that'd be done with a new pair of > > 'begin/end code caching' functions that would be called at the > > appropriate places. The new code in dis_asm_read_memory would > > then be pushed to target.c, close to where stack cache is handled. > > How hard would it be to do that now? AFAICS, it is not hard. We've already had TARGET_OBJECT_STACK_MEMORY, so it is straightforward to add TARGET_OBJECT_CODE_MEMORY, and disas and skip_prologue can use it. -- Yao (齐尧)