[PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet

[Hui Zhu <hui_zhu@mentor.com>]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

We found that in powerpc arch board, it cannot pass some dprintf test:
FAIL: gdb.base/dprintf.exp: dprintf info 2 (pattern 6)
FAIL: gdb.mi/mi-dprintf.exp: mi expect stop (unknown output after running)
FAIL: gdb.mi/mi-dprintf.exp: mi 1st dprintf, agent (unknown output after running)

This because the gdbserver will always tell GDB that it support target-side breakpoint conditions and commands.  So "set dprintf-style agent" will always got success.
But target-side breakpoint conditions and commands are depend on 'Z' packet because GDB just can post target-side breakpoint conditions and commands with 'Z' packet.
The test will check if "set dprintf-style agent" success or not.  Because it will always succes.  So GDB change the commands to agent-printf that will make test get fail.

So I make a patch to check if the low-target support insert_point before return support target-side breakpoint conditions and commands.

Tested in powerpc-linux target.

2013-10-21  Hui Zhu  <yao@codesourcery.com>

	* linux-low.c (linux_supports_insert_point): New.
	(linux_target_op): Add linux_supports_insert_point.
	* server.c (handle_query): Check target_supports_insert_point
	before return support target-side breakpoint conditions and
	commands.
	* target.h (target_ops): Add supports_insert_point.
	(target_supports_insert_point): New.

[-- Attachment #2: fix-dprintf.txt --]
[-- Type: text/plain, Size: 2222 bytes --]

--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -4929,6 +4929,15 @@ linux_supports_range_stepping (void)
   return (*the_low_target.supports_range_stepping) ();
 }
 
+static int
+linux_supports_insert_point (void)
+{
+  if (the_low_target.insert_point != NULL)
+    return 1;
+
+  return 0;
+}
+
 /* Enumerate spufs IDs for process PID.  */
 static int
 spu_enumerate_spu_ids (long pid, unsigned char *buf, CORE_ADDR offset, int len)
@@ -5825,6 +5834,7 @@ static struct target_ops linux_target_op
   NULL,
 #endif
   linux_supports_range_stepping,
+  linux_supports_insert_point,
 };
 
 static void
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -1806,9 +1806,16 @@ handle_query (char *own_buf, int packet_
 	  strcat (own_buf, ";tracenz+");
 	}
 
-      /* Support target-side breakpoint conditions and commands.  */
-      strcat (own_buf, ";ConditionalBreakpoints+");
-      strcat (own_buf, ";BreakpointCommands+");
+      /* GDB will send target-side breakpoint conditions and commands packets
+         with insert point packets.  So if target doesn't support insert
+         point, it should not support target-side breakpoint conditions
+         and commands packets.  */
+      if (target_supports_insert_point ())
+	{
+	  /* Support target-side breakpoint conditions and commands.  */
+	  strcat (own_buf, ";ConditionalBreakpoints+");
+	  strcat (own_buf, ";BreakpointCommands+");
+	}
 
       if (target_supports_agent ())
 	strcat (own_buf, ";QAgent+");
--- a/gdb/gdbserver/target.h
+++ b/gdb/gdbserver/target.h
@@ -365,6 +365,9 @@ struct target_ops
 
   /* Return true if target supports range stepping.  */
   int (*supports_range_stepping) (void);
+
+  /* Return true if target supports insert_point.  */
+  int (*supports_insert_point) (void);
 };
 
 extern struct target_ops *the_target;
@@ -504,6 +507,10 @@ int kill_inferior (int);
   (the_target->supports_range_stepping ? \
    (*the_target->supports_range_stepping) () : 0)
 
+#define target_supports_insert_point() \
+  (the_target->supports_insert_point ? \
+   (*the_target->supports_insert_point) () : 0)
+
 /* Start non-stop mode, returns 0 on success, -1 on failure.   */
 
 int start_non_stop (int nonstop);