Re: [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts.

[Keith Seitz <keiths@redhat.com>]

On 10/01/2013 06:39 AM, Pierre Muller wrote:
> (gdb) PASS: gdb.base/printcmds.exp: set print elements 0
> p teststring
> $554 = <__cygwin_cxx_malloc+128> "teststring contents"
[snip]

Ah, that's good enough evidence for me.

>>>     The last errors were generated by the use of Ctrl-V
>>> to avoid problems with possible association of @ to kill command.
>>>     mingw GDB doesn't handle this Ctrl-V, so I conditionally removed it
> for
>>> *-*-mingw* hosts.
>>
>> This isn't so much a question for you specifically, but I thought I'd
>> throw this out to the greater wisdom of the list.
>>
>> I searched around the test suite and found a bunch of places where this
>> character is used without the ^V hack. Is it (still) necessary at all?
>> Perhaps we can just get rid of it entirely?
>
>    I have no idea...
> I just played it save by disabling only for MinGW hosts...

I say get rid of it. This is the only place where this is done, and if 
this is really necessary, there are several other places where it should 
have been done. So I'm assuming it is no longer strictly necessary.

>> Otherwise, given the harmless nature of the changes, I'd recommend that
>> a maintainer approve this.

With that, I think a maintainer should give this a final review and 
approval.

Keith