From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21402 invoked by alias); 24 Oct 2013 08:26:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21384 invoked by uid 89); 24 Oct 2013 08:26:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Oct 2013 08:26:42 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VZGFb-0004wu-3F from Yao_Qi@mentor.com ; Thu, 24 Oct 2013 01:26:39 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 24 Oct 2013 01:26:39 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Thu, 24 Oct 2013 01:26:38 -0700 Message-ID: <5268D967.2000703@codesourcery.com> Date: Thu, 24 Oct 2013 08:26:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii CC: Subject: Re: [PATCH 5/5] set/show code-cache NEWS and doc References: <1382516855-32218-1-git-send-email-yao@codesourcery.com> <1382516855-32218-6-git-send-email-yao@codesourcery.com> <83sivshuux.fsf@gnu.org> In-Reply-To: <83sivshuux.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00748.txt.bz2 On 10/23/2013 11:25 PM, Eli Zaretskii wrote: > Thanks. However, this (and even more importantly, the manual) should > explain what is "code" in this context. "Code" is too general a word > to hope that the reader will immediately understand what you mean. > I go through gdb.texinfo, and find "program code" is used in some places. I choose it. > Also, the last sentence above should be in the manual; it's not good > that the manual has less details than NEWS. OK, add one line in the manual to mention that this improves disassemble. How about this? -- Yao (齐尧) gdb: 2013-10-23 Yao Qi * NEWS: Add note on new "set code-cache" option. gdb/doc: 2013-10-23 Yao Qi * gdb.texinfo (Caching Remote Data): Document new `set/show stack-cache' option. --- gdb/NEWS | 6 ++++++ gdb/doc/gdb.texinfo | 15 ++++++++++++++- 2 files changed, 20 insertions(+), 1 deletions(-) diff --git a/gdb/NEWS b/gdb/NEWS index 10834df..10d5804 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -98,6 +98,12 @@ set range-stepping show range-stepping Control whether target-assisted range stepping is enabled. +set code-cache +show code-cache + Use more aggressive caching for accesses to the program code. This + improves performance of remote debugging (particularly disassemble) + without affecting correctness. + * You can now use a literal value 'unlimited' for options that interpret 0 or -1 as meaning "unlimited". E.g., "set trace-buffer-size unlimited" is now an alias for "set diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 44fb174..5770382 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -10796,7 +10796,8 @@ Therefore, by default, @value{GDBN} only caches data known to be on the stack@footnote{In non-stop mode, it is moderately rare for a running thread to modify the stack of a stopped thread in a way that would interfere with a backtrace, and caching of -stack reads provides a significant speed up of remote backtraces.}. +stack reads provides a significant speed up of remote backtraces.} or +in the program code. Other regions of memory can be explicitly marked as cacheable; see @pxref{Memory Region Attributes}. @@ -10821,6 +10822,18 @@ caching. By default, this option is @code{ON}. @item show stack-cache Show the current state of data caching for memory accesses. +@kindex set code-cache +@item set code-cache on +@itemx set code-cache off +Enable or disable caching of program code accesses. When @code{ON}, +use caching. By default, this option is @code{ON}. This improves +performance of disassemble in remote debugging without affecting +correctness. + +@kindex show code-cache +@item show code-cache +Show the current state of data caching for program code accesses. + @kindex info dcache @item info dcache @r{[}line@r{]} Print the information about the data cache performance. The -- 1.7.7.6