From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/5] set/show code-cache
Date: Fri, 25 Oct 2013 14:35:00 -0000 [thread overview]
Message-ID: <526A8164.7040509@codesourcery.com> (raw)
In-Reply-To: <CADPb22SrY50xeRsKb3T8cY=qYVf=QmMicpRcr9_m79nD0MpwHQ@mail.gmail.com>
On 10/25/2013 03:47 PM, Doug Evans wrote:
> While perhaps it usually won't be a problem (*1), it's odd to have two caches.
At the very beginning, I use single dcache for both stack access and
code access. However, it is odd that command "set stack-cache off"
invalidates code caches, so I decide to add a new cache dedicated to
code access.
> If I do x/10x $addr and then x/10i $addr will both caches get populated?
No, "x/10i $addr" gets code cache populated, while "x/10x $addr" doesn't
get "general" or "stack" cache populated, unless I set memory attribute
cache for this area.
> [Will there be latent bugs due to "storing the same thing twice"?
> (which has been a source of bugs in gdb) Plus there's the extra
> complexity of keeping both in sync.]
"Storing the same thing twice" may introduce bugs, but "store two things
together" is not good either :).
The code keeping caches in sync is localized, and probably we can move
them into a new file target-cache.c. I don't see too much complexity
here and the disassembly is sped up, so it is worth doing it, IMO.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-10-25 14:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 8:29 [PATCH 0/5] Cache code access for disassemble Yao Qi
2013-10-23 8:29 ` [PATCH 3/5] set/show code-cache Yao Qi
2013-10-25 7:47 ` Doug Evans
2013-10-25 14:35 ` Yao Qi [this message]
2013-10-25 15:57 ` Doug Evans
2013-10-26 13:24 ` Yao Qi
2013-10-28 18:33 ` Doug Evans
2013-10-23 8:29 ` [PATCH 1/5] Add REGISTRY for struct address_space Yao Qi
2013-10-28 20:46 ` Tom Tromey
2013-10-23 8:29 ` [PATCH 2/5] Associate target_dcache to address_space Yao Qi
2013-10-23 16:37 ` Tom Tromey
2013-10-24 8:33 ` Yao Qi
2013-10-28 20:49 ` Tom Tromey
2013-10-28 21:51 ` Doug Evans
2013-10-23 8:29 ` [PATCH 5/5] set/show code-cache NEWS and doc Yao Qi
2013-10-23 15:25 ` Eli Zaretskii
2013-10-24 8:26 ` Yao Qi
2013-10-24 15:21 ` Eli Zaretskii
2013-10-25 9:35 ` Yao Qi
2013-10-25 10:01 ` Eli Zaretskii
2013-11-02 0:25 ` Yao Qi
2013-11-02 7:06 ` Eli Zaretskii
2013-10-23 8:29 ` [PATCH 4/5] Use target_read_code in disassemble Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526A8164.7040509@codesourcery.com \
--to=yao@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).