From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5379 invoked by alias); 25 Oct 2013 16:21:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5367 invoked by uid 89); 25 Oct 2013 16:21:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2013 16:21:36 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9PGLYJx025385 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 25 Oct 2013 12:21:34 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9PGLXQr028188; Fri, 25 Oct 2013 12:21:33 -0400 Message-ID: <526A9A8C.3060606@redhat.com> Date: Fri, 25 Oct 2013 16:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 05/17] fix up gdb.xml References: <1382129374-18344-1-git-send-email-tromey@redhat.com> <1382129374-18344-6-git-send-email-tromey@redhat.com> In-Reply-To: <1382129374-18344-6-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00803.txt.bz2 On 10/18/2013 09:49 PM, Tom Tromey wrote: > -# Similarly, we need to copy files under test into the objdir. > -proc load_description { file errmsg } { > +# Similarly, we need to copy files under test into the objdir. If > +# SHOULD_CD is set, it causes the gdb under test to "cd" to the > +# directory holding the XML code. This should only be set once; so > +# the first call should use it and subsequent calls should not. > +proc load_description { file errmsg {should_cd 1} } { > global srcdir > global subdir > global gdb_prompt > global core-regs > global architecture > + global remote_filename > > - file delete "$subdir/regs.xml" > + set regs_file [standard_output_file regs.xml] Sorry, I guess I'm a little dense, as this CD stuff still confused me. IIUC, we only CD once, because subsequent calls to load_description will use the cwd set from the first call. Is that right? (I can't tell whether the path passed to "cd" is relative -- if so, if we don't cd back to the previous dir, then that'd be clearly a problem). So that I understand, given we only CD if !remote-host, cd'ing before calling load_description in the first place work be the same then, right? Like: set regs_file [standard_output_file regs.xml] if {![is_remote host]} { gdb_test "cd [file dirname $regs_file]" "Working directory .*" \ "cd to directory holding xml" } load_description "extra-regs.xml" "" ... load_description "core-only.xml" "" Thanks, -- Pedro Alves