From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6800 invoked by alias); 25 Oct 2013 16:22:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6788 invoked by uid 89); 25 Oct 2013 16:22:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2013 16:21:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9PGLwce016180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 25 Oct 2013 12:21:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9PGLuDs026490; Fri, 25 Oct 2013 12:21:57 -0400 Message-ID: <526A9AA4.1040304@redhat.com> Date: Fri, 25 Oct 2013 16:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 11/17] introduce relative_filename and use it References: <1382129374-18344-1-git-send-email-tromey@redhat.com> <1382129374-18344-12-git-send-email-tromey@redhat.com> In-Reply-To: <1382129374-18344-12-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00805.txt.bz2 On 10/18/2013 09:49 PM, Tom Tromey wrote: > This introduces a new relative_filename proc to gdb.exp and changes > some tests to use it. This helps make these tests parallel-safe. > > * gdb.base/fullname.exp: Use standard_output_file, > relative_filename. > * gdb.base/hashline1.exp: Use standard_testfile, > standard_output_file, relative_filename, clean_restart. > * gdb.base/hashline2.exp: Use standard_testfile, > standard_output_file, relative_filename. > * gdb.base/hashline3.exp: Use standard_testfile, > standard_output_file, relative_filename. > * lib/gdb.exp (relative_filename): New proc. ... It seems like gdb.base/hashline2.exp doesn't actually use relative_filename. Was that a mistake? > diff --git a/gdb/testsuite/gdb.base/hashline2.exp b/gdb/testsuite/gdb.base/hashline2.exp > index d7ee4a7..cd748ca 100644 > --- a/gdb/testsuite/gdb.base/hashline2.exp > +++ b/gdb/testsuite/gdb.base/hashline2.exp > @@ -21,16 +21,15 @@ > # srcfile is in objdir because we need to machine generate it in order > # to get the correct path in the #line directive. > > -set testfile "hashline2" > -set srcfile "${testfile}.c" > -set binfile "${objdir}/${subdir}/${testfile}" > +standard_testfile .c > > -set fd [open ${objdir}/${subdir}/${srcfile} w] > -puts $fd "#line 2 \"///[pwd]/${subdir}/${srcfile}\"" > +set new_srcfile [standard_output_file $srcfile] > +set fd [open $new_srcfile w] > +puts $fd "#line 2 \"///${new_srcfile}\"" > puts $fd "int main () { return 0; } /* set breakpoint here */" > close $fd > > -if { [gdb_compile "${objdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { > +if { [gdb_compile $new_srcfile "${binfile}" executable {debug}] != "" } { > untested hashline2.exp > return -1 > } > @@ -40,7 +39,7 @@ gdb_start > gdb_reinitialize_dir $srcdir/$subdir > gdb_load ${binfile} > > -set bp_location [gdb_get_line_number "set breakpoint here" ${objdir}/${subdir}/${srcfile}] > +set bp_location [gdb_get_line_number "set breakpoint here" ${new_srcfile}] > > # Try to set a breakpoint on the specified file location. > -- Pedro Alves