From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7556 invoked by alias); 25 Oct 2013 16:22:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7545 invoked by uid 89); 25 Oct 2013 16:22:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2013 16:22:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9PGMHxt004386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 25 Oct 2013 12:22:17 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9PGMGeq003763; Fri, 25 Oct 2013 12:22:17 -0400 Message-ID: <526A9AB8.1090500@redhat.com> Date: Fri, 25 Oct 2013 16:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 07/17] fix up gdb.trace References: <1382129374-18344-1-git-send-email-tromey@redhat.com> <1382129374-18344-8-git-send-email-tromey@redhat.com> In-Reply-To: <1382129374-18344-8-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00806.txt.bz2 On 10/18/2013 09:49 PM, Tom Tromey wrote: > +if {![is_remote host] && ![is_remote target]} { > + set tfile_basic [standard_output_file tfile-basic.tf] > + set tfile_dir [file dirname $tfile_basic]/ > + set purely_local 1 > +} else { > + set purely_local 0 > + set tfile_basic tfile-basic.tf > + set tfile_dir "" > +} > + Minor, minor nit. Can you define the variables in the same order in both branches? My eyes crossed a little going back and forth comparing the values of both branches, for the branches not having the same pattern. Sorry for the trouble. > +if {![is_remote host] && ![is_remote target]} { > + set tfile_basic [standard_output_file tfile-basic.tf] > + set tfile_error [standard_output_file tfile-error.tf] > + set tfile_dir [file dirname $tfile_basic]/ > + set purely_local 1 > +} else { > + set tfile_basic tfile-basic.tf > + set tfile_error tfile-error.tf > + set purely_local 0 > + set tfile_dir "" > +} > + Here too, and also in tfile.exp. -- Pedro Alves