From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10243 invoked by alias); 28 Oct 2013 16:04:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10234 invoked by uid 89); 28 Oct 2013 16:04:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2013 16:04:06 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9SG44LT021022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Oct 2013 12:04:04 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9SG432Z001230; Mon, 28 Oct 2013 12:04:03 -0400 Message-ID: <526E8AF2.7050202@redhat.com> Date: Mon, 28 Oct 2013 16:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v4 2/9] add "this" pointers to more target APIs References: <1382464769-2465-1-git-send-email-tromey@redhat.com> <1382464769-2465-3-git-send-email-tromey@redhat.com> In-Reply-To: <1382464769-2465-3-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00863.txt.bz2 On 10/22/2013 06:59 PM, Tom Tromey wrote: > @@ -4758,8 +4756,8 @@ static void > linux_nat_close (void) > { > /* Unregister from the event loop. */ > - if (linux_nat_is_async_p ()) > - linux_nat_async (NULL, 0); > + if (linux_nat_is_async_p (linux_ops)) > + linux_nat_async (linux_ops, NULL, 0); It doesn't matter much since linux_nat_async doesn't use it's argument, but FYI, this one here doesn't look 100% correct. "linux_ops" is the single-threaded target linux-nat itself delegates some work to (it's never pushed anywhere, etc.). Ideally, to_close would be passed in a "this" pointer too. > static int > -record_full_stopped_by_watchpoint (void) > +record_full_stopped_by_watchpoint (struct target_ops *ops) > { > if (RECORD_FULL_IS_REPLAY) > return record_full_hw_watchpoint; > else > - return record_full_beneath_to_stopped_by_watchpoint (); > + return record_full_beneath_to_stopped_by_watchpoint (find_target_beneath (ops)); > } > Line too long. -- Pedro Alves