From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 137B6385840B for ; Tue, 9 Apr 2024 13:33:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 137B6385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 137B6385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712669639; cv=none; b=PAS09/CHx3ERM90Hf1C6QW42an/V6c2YzxyY8pb905xl/KXj2rgKcfStQ/+OtIL/Zbg3YHTGDVv2bop9y1Iqhu1Oeey1AnnlFSAh0Hp5GDLA81w/xHLvUhCxI7y5NtRTNO4ZV9W5UjCLVYHHyVaVir/nWE7zR0R1Sq0uU/wasTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712669639; c=relaxed/simple; bh=7o6s9dYwq7fFt9idXQScaRMvo7ttVttfQTmUND+4zY8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sA3vbx2sSjjXH8abcL8JlkfboYUw6c+WcEGS2/YwqqoqX3VXvBiXQP3LfjsA9iEBO8lOEHBmBRHDeKHGgoKcB1GrSwiMs4oGZ3YFRaK/i5nQSvbCo9SFFc7PJGQ7Zh4QMPOAE7XNaTBOsi+ZnXhS0sYvp1jEmMooGv43Kvb0phE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712669636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ROP2HhNruxdXRMQ7gDMxHGf5JskiKtQMRE8LEp1ysEM=; b=T1MParC1XDKzSBn4Yh2qaQ6uHwHShD1xlIBvbgZiC1XTCiZjoCPjh2DyJk3X2n4CFZ79gS Vw1Azb7LCfezPdSRfH7P4uJjJzId7QNh4Ia/adocPMGJDFHR/7uGbVkKsA3K8We1FnJXQC 487jSVE4KCKIMOuIpsBMDSRfjyepNDk= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-u_cSv4EGN0qIScRYCLadsw-1; Tue, 09 Apr 2024 09:33:54 -0400 X-MC-Unique: u_cSv4EGN0qIScRYCLadsw-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-434e545b504so4974921cf.1 for ; Tue, 09 Apr 2024 06:33:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712669634; x=1713274434; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ROP2HhNruxdXRMQ7gDMxHGf5JskiKtQMRE8LEp1ysEM=; b=ugGS4Dap9iTEi4QB3DdXSkJ8/4h+3NL0EmlCKuRXTPUMsz30dyFmMlOMNYUso+fpPr RTT98elrPPxGSpAJP3JZd+jVrLqWz/q3GcGOmmkk4J+jyWf9gh7Xwi1Qfkrpj91FD+Sp FbLrPYrlbpHyqyffiiVVMZ5Ft0qmLihxk3fkyr3UVoKiByxw+ErWeFTFAw07wiw3Nq7E otdDTJtjfUUnaPuGNlt4ZM3+tQ3xwGfhHD1+GBeGmB4ND4FLm1W5C+QMq5YrMintzhml 6tsHew4W2vBQFBuKZRuxwlKMNRYC+opqmg9sQAdsTGvMhJjZqzDtREq3Og+sWG6QGj6G uq4A== X-Gm-Message-State: AOJu0Yw/QZuR/Pg9FpTJFyOo4cjAiJOJq2OVsOUjZJqfRjHHUKF/VUaC +NBRgIfGoYOtN3l6ypEOS8B7BzSdJapXT7VWIko6e4F5gL5TcEbzV8kbbfNtwA+ACC74nmjs+r5 4zp4UDhD22LoS2DgPSfQ+BUB5I0BfZm2gCpEgwHe+XbMg4c2v0cDqxGbp300= X-Received: by 2002:a05:622a:2692:b0:434:7e31:b914 with SMTP id kd18-20020a05622a269200b004347e31b914mr5608412qtb.56.1712669634286; Tue, 09 Apr 2024 06:33:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGekmR+IBQmUEwHtH8vZNKQzch6fRbNAjnNEGz8pB1s3DOe8CalmcYQ0c3p9cwhj60avCBU2w== X-Received: by 2002:a05:622a:2692:b0:434:7e31:b914 with SMTP id kd18-20020a05622a269200b004347e31b914mr5608392qtb.56.1712669633793; Tue, 09 Apr 2024 06:33:53 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id hj11-20020a05622a620b00b00434368a34a5sm4562161qtb.64.2024.04.09.06.33.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 06:33:53 -0700 (PDT) Message-ID: <5278bd11-8bfd-4e22-9d9b-22899769c148@redhat.com> Date: Tue, 9 Apr 2024 10:33:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] gdb: introduce ability to disable frame unwinders To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20240408201915.1482831-1-blarsen@redhat.com> <20240408201915.1482831-5-blarsen@redhat.com> <86bk6jxnen.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86bk6jxnen.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------StJc4uBdAEok9ZPasIJCYv0b" Content-Language: en-US X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------StJc4uBdAEok9ZPasIJCYv0b Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the review. I'll fix everything else you mentioned. On 4/8/24 23:47, Eli Zaretskii wrote: >> +Disable or enable frame unwinders. This is meant only as a testing tool, and >> +@value{GDBN} is not guaranteed to work properly if it is unable to find >> +valid frame unwinders. >> + >> +The meaning of each of the invocations are as follows: >> + >> +@table @samp >> +@item @code{-all} >> +Disable or enable all unwinders. >> +@item @code{-name} @var{NAME} >> +@var{NAME} is the exact name of the unwinder to be disabled or enabled. >> +@item [@code{-class}] @var{CLASS} >> +@var{CLASS} is the class of frame unwinders to be disabled or enabled. >> +The class may include the prefix @code{FRAME_UNWINDER_}, but it is not >> +required. >> +@end table >> + >> +@var{NAME} and @var{CLASS} are always case insensitive. If no option >> +starting wth @code{-} is given, @value{GDBN} assumes @code{-class}. > I think this command should be moved to after "maint info > frame-unwinders", and it should say that the list of available > unwinders is shown by that command. Also, I suppose what you call > "class" is what "maint info frame-unwinders" displays as "Type"? Or > is it something else? If the latter, the manual should tell how to > know which classes are available. The unwinder class was introduced by patch 2 of this series (which I now realize I forgot to add NEWS and doc changes). Where would I add base information about frame unwinders like this? -- Cheers, Guinevere Larsen She/Her/Hers --------------StJc4uBdAEok9ZPasIJCYv0b--