From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10886 invoked by alias); 5 Nov 2013 18:16:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10877 invoked by uid 89); 5 Nov 2013 18:16:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2013 18:16:11 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA5IG17m024813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Nov 2013 13:16:01 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rA5IG0rm028288; Tue, 5 Nov 2013 13:16:00 -0500 Message-ID: <527935DF.4060406@redhat.com> Date: Tue, 05 Nov 2013 18:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Burgess CC: "gdb-patches@sourceware.org" , lgustavo@codesourcery.com Subject: Re: I think permanent breakpoints are fundamentally broken as is References: <52614A15.7070301@broadcom.com> <52615F0B.4050008@redhat.com> <526FF5D7.7000909@broadcom.com> In-Reply-To: <526FF5D7.7000909@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00087.txt.bz2 On 10/29/2013 05:52 PM, Andrew Burgess wrote: > On 18/10/2013 5:17 PM, Pedro Alves wrote: >> On 10/18/2013 03:47 PM, Andrew Burgess wrote: >>> This patch: >>> https://sourceware.org/ml/gdb-patches/2012-01/msg00964.html >>> >>> introduced what I believe is a stray line that causes permanent >>> breakpoints to become normal breakpoints if the user ever tries >>> to "enable" the permanent breakpoint. >> >> I actually think "permanent breakpoints" are quite weird beasts, >> both from a user interface, and implementation perspectives. > > > > OK, given all you've said I'd like to just commit the patch below. This is basically removing the stray line I mention above but without adding any new tests. > > I'd never even heard about "permanent breakpoints" before I spotted the odd looking extra line, so only added the tests as "good practice" to > ensure the same bug was not added again. > > Given that we're not really sure exactly how permanent breakpoints should operate I think just removing the stray line for now would be best, then if anyone re-works permanent breakpoints they'll not have to find/consider this tiny "ooops". > > OK to apply? OK. > > Thanks, > Andrew > > gdb/ChangeLog > > 2013-10-29 Andrew Burgess > > * breakpoint.c (enable_breakpoint_disp): Remove setting of > enabled_state for permanent breakpoints. -- Pedro Alves