* [PATCH] [PR gdb/15224] Enable "set history save on" by default
@ 2013-11-06 12:12 Muhammad Bilal
2013-11-06 12:15 ` Pedro Alves
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Bilal @ 2013-11-06 12:12 UTC (permalink / raw)
To: palves; +Cc: gdb-patches, Muhammad Bilal
Hi Pedro,
This patch enable the 'set history save on' by default.
This patch is independent of 'Change the default set history filename to ~/.gdb_history'.
so I think we should go forward.
OK?
2013-11-06 Muhammad Bilal <mbilal@codesourcery.com>
PR cli/15224
* top.c (init_main): 'set history save on' by default.
---
gdb/top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/top.c b/gdb/top.c
index 7d928e1..d7409d9 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1708,7 +1708,7 @@ init_main (void)
/* Set the important stuff up for command editing. */
command_editing_p = 1;
history_expansion_p = 0;
- write_history_p = 0;
+ write_history_p = 1;
/* Setup important stuff for command line editing. */
rl_completion_word_break_hook = gdb_completion_word_break_characters;
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [PR gdb/15224] Enable "set history save on" by default
2013-11-06 12:12 [PATCH] [PR gdb/15224] Enable "set history save on" by default Muhammad Bilal
@ 2013-11-06 12:15 ` Pedro Alves
0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2013-11-06 12:15 UTC (permalink / raw)
To: Muhammad Bilal; +Cc: gdb-patches
On 11/06/2013 10:28 AM, Muhammad Bilal wrote:
> Hi Pedro,
>
> This patch enable the 'set history save on' by default.
>
> This patch is independent of 'Change the default set history filename to ~/.gdb_history'.
> so I think we should go forward.
No it's not. I don't think we should ever enable history by
default with the current default location. This should be
the last patch applied.
--
Pedro Alves
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-06 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-06 12:12 [PATCH] [PR gdb/15224] Enable "set history save on" by default Muhammad Bilal
2013-11-06 12:15 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).