[PATCH] [PR gdb/16123] Modify GDB testsuite to always disable history saving

[PATCH] [PR gdb/16123] Modify GDB testsuite to always disable history saving

[Muhammad Bilal]

    Hi Pedro,

    History saving on testsuite should always be disable after enabling the history save on by default
    Please find below patch for this purpose.

    This patch is independent of 'Change the default set history filename to ~/.gdb_history'.
    so I think we should go forward.

    OK?

gdb/testsuit
2013-11-06  Muhammad Bilal  <mbilal@codesourcery.com>

	PR gdb/16123
	* lib/gdb.exp: Add '-ex "set history save off"' to
	INTERNAL_GDBFLAGS.
---
 gdb/testsuite/lib/gdb.exp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index b8b21ab..e937625 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -59,7 +59,7 @@ set BUILD_DATA_DIRECTORY "[pwd]/../data-directory"
 # INTERNAL_GDBFLAGS contains flags that the testsuite requires.
 global INTERNAL_GDBFLAGS
 if ![info exists INTERNAL_GDBFLAGS] {
-    set INTERNAL_GDBFLAGS "-nw -nx -data-directory $BUILD_DATA_DIRECTORY"
+    set INTERNAL_GDBFLAGS "-nw -nx -ex \"set history save off\" -data-directory $BUILD_DATA_DIRECTORY"
 }
 
 # The variable gdb_prompt is a regexp which matches the gdb prompt.
-- 
1.7.9.5

Re: [PATCH] [PR gdb/16123] Modify GDB testsuite to always disable history saving

[Pedro Alves]

On 11/06/2013 10:27 AM, Muhammad Bilal wrote:
> 
>     Hi Pedro,
> 
>     History saving on testsuite should always be disable after enabling the history save on by default
>     Please find below patch for this purpose.
> 
>     This patch is independent of 'Change the default set history filename to ~/.gdb_history'.
>     so I think we should go forward.
> 
>     OK?

This is OK, but it should only be applied right before the
patch that enables history by default.  There's no point in
applying this otherwise.

-- 
Pedro Alves