Re: [PATCH 0/2] GDB process record and reverse debugging improvements for arm*-linux*

[Omair Javaid <omair.javaid@linaro.org>]

On Thu 24 Oct 2013 06:42:50 AM PKT, Yao Qi wrote:
> On 10/24/2013 08:09 AM, Omair Javaid wrote:
>> --- gdb/NEWS 11 Oct 2013 13:51:26 -0000 1.622
>> +++ gdb/NEWS 23 Oct 2013 20:34:42 -0000
>> @@ -3,6 +3,12 @@
>>
>>   *** Changes since GDB 7.6
>>
>> +* Improved support of process record-replay and reverse debugging on
>> +  arm*-linux* targets.
>> +
>> +Support for thumb32 instructions and syscall recording has been added.
>
> This change is user visible...
>
>> +gdb/testsuite/gdb.reverse is now enabled for arm*-linux* targets.
>> +
>
> while this is not.  This line is not necessary in NEWS.
>

Here is an updated patch.
== PATCH 0 ==

This patch adds a news entry about improved process record-replay on
arm*-linux* targets.
It also adds linux-record.o to gdb_target_obs in configure.tgt and
enables gdb.reverse testsuite for arm*-linux* targets.

gdb:

2013-11-08  Omair Javaid  <omair.javaid@linaro.org>

	* NEWS: Add note on improved process record-replay on arm*-linux*
	targets.
	* configure.tgt: Add linux-record.o to gdb_target_obs.

gdb/testsuite:

2013-10-24  Omair Javaid  <omair.javaid@linaro.org>

	* lib/gdb.exp: Enable gdb.reverse testsuite for arm*-linux* targets.

Index: gdb/NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.622
diff -u -p -r1.622 NEWS
--- gdb/NEWS	11 Oct 2013 13:51:26 -0000	1.622
+++ gdb/NEWS	7 Nov 2013 23:58:26 -0000
@@ -3,6 +3,10 @@

 *** Changes since GDB 7.6

+* Improved support of process record-replay and reverse debugging on
+  arm*-linux* targets. Support for thumb32 and syscall instructions
+  recording has been added.
+
 * GDB now supports Fission DWP file format version 2.
   http://gcc.gnu.org/wiki/DebugFission

Index: gdb/configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.281
diff -u -p -r1.281 configure.tgt
--- gdb/configure.tgt	1 Oct 2013 13:21:17 -0000	1.281
+++ gdb/configure.tgt	7 Nov 2013 23:58:29 -0000
@@ -89,7 +89,7 @@ arm*-wince-pe | arm*-*-mingw32ce*)
 arm*-*-linux*)
 	# Target: ARM based machine running GNU/Linux
 	gdb_target_obs="arm-tdep.o arm-linux-tdep.o glibc-tdep.o \
-			solib-svr4.o symfile-mem.o linux-tdep.o"
+			solib-svr4.o symfile-mem.o linux-tdep.o linux-record.o"
 	build_gdbserver=yes
 	;;
 arm*-*-netbsd* | arm*-*-knetbsd*-gnu)
Index: gdb/testsuite/lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.250
diff -u -p -r1.250 gdb.exp
--- gdb/testsuite/lib/gdb.exp	18 Oct 2013 20:40:03 -0000	1.250
+++ gdb/testsuite/lib/gdb.exp	7 Nov 2013 23:58:32 -0000
@@ -1774,7 +1774,8 @@ proc supports_process_record {} {
 	return [target_info gdb,use_precord]
     }

-    if { [istarget "x86_64-*-linux*"] || [istarget 
"i\[34567\]86-*-linux*"] } {
+    if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
+         || [istarget "i\[34567\]86-*-linux*"] } {
 	return 1
     }

@@ -1789,7 +1790,8 @@ proc supports_reverse {} {
 	return [target_info gdb,can_reverse]
     }

-    if { [istarget "x86_64-*-linux*"] || [istarget 
"i\[34567\]86-*-linux*"] } {
+    if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
+         || [istarget "i\[34567\]86-*-linux*"] } {
 	return 1
     }