From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/Ada(v2) 1/3] Add command to list Ada exceptions
Date: Fri, 08 Nov 2013 13:40:00 -0000 [thread overview]
Message-ID: <527CDD03.9000200@redhat.com> (raw)
In-Reply-To: <1383912219-13012-2-git-send-email-brobecker@adacore.com>
Hi Joel,
Only minor comments.
On 11/08/2013 12:03 PM, Joel Brobecker wrote:
> (DEF_VEC_O(ada_exc_info): New vector.
Something odd here.
> gdb/testsuite/ChangeLog:
>
> * info_exc: New testcase.
gdb.ada missing.
> + /* Next, find all exceptions whose scope is local and accessible
> + from the currently selected frame. */
> +
> + if (target_has_registers)
> + {
Should be has_stack_frames.
--
Pedro Alves
next prev parent reply other threads:[~2013-11-08 12:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 12:04 RFA/Ada (v2) new CLI + GDB/MI commands " Joel Brobecker
2013-11-08 12:04 ` [RFA/Ada(v2) 3/3] Document "info exceptions" and "-info-ada-exception" new commands Joel Brobecker
2013-11-08 14:21 ` Eli Zaretskii
2013-11-10 9:49 ` Joel Brobecker
2013-11-12 4:07 ` Joel Brobecker
2013-11-08 12:05 ` [RFA/Ada(v2) 1/3] Add command to list Ada exceptions Joel Brobecker
2013-11-08 13:40 ` Pedro Alves [this message]
2013-11-08 14:10 ` Joel Brobecker
2013-11-08 15:47 ` Tom Tromey
2013-11-08 16:13 ` Joel Brobecker
2013-11-08 16:32 ` Tom Tromey
2013-11-10 6:29 ` Joel Brobecker
2013-11-11 14:48 ` Tom Tromey
2013-11-13 17:04 ` Tom Tromey
2013-11-13 18:29 ` Joel Brobecker
2013-11-15 7:28 ` Joel Brobecker
2013-11-15 15:53 ` Tom Tromey
2013-11-15 17:06 ` Joel Brobecker
2013-11-15 17:48 ` Tom Tromey
2013-11-15 18:01 ` Joel Brobecker
2013-11-15 18:23 ` Tom Tromey
2013-11-16 3:51 ` pushed: " Joel Brobecker
2013-11-08 12:27 ` [RFA/Ada(v2) 2/3] Implement GDB/MI equivalent of "info exceptions" CLI command Joel Brobecker
2013-11-12 3:38 ` RFA/Ada (v2) new CLI + GDB/MI commands to list Ada exceptions Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527CDD03.9000200@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).